test_posix: Android 'id -G' is entirely wrong or missing the effective gid

[xdegaye]

BPO	26944
Nosy	@vstinner, @larryhastings, @bitdancer, @xdegaye, @serhiy-storchaka, @moreati, @yan12125
PRs	[Do Not Merge] Convert Misc/NEWS so that it is managed by towncrier #552
Files	test_getgroups.patch test_getgroups_2.patch test_getgroups_3.patch test_getgroups_4.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/xdegaye'
closed_at = <Date 2016-10-19.09:11:29.617>
created_at = <Date 2016-05-04.08:01:13.201>
labels = ['3.7', 'type-bug', 'tests']
title = "test_posix: Android 'id -G' is entirely wrong or missing the effective gid"
updated_at = <Date 2017-03-31.16:36:11.270>
user = 'https://github.com/xdegaye'

bugs.python.org fields:

activity = <Date 2017-03-31.16:36:11.270>
actor = 'dstufft'
assignee = 'xdegaye'
closed = True
closed_date = <Date 2016-10-19.09:11:29.617>
closer = 'xdegaye'
components = ['Tests']
creation = <Date 2016-05-04.08:01:13.201>
creator = 'xdegaye'
dependencies = []
files = ['42943', '43817', '44143', '45067']
hgrepos = []
issue_num = 26944
keywords = ['patch']
message_count = 15.0
messages = ['264789', '264793', '265251', '266070', '270936', '270937', '270943', '271257', '271273', '271280', '271285', '271291', '273068', '278531', '278969']
nosy_count = 8.0
nosy_names = ['vstinner', 'larry', 'r.david.murray', 'xdegaye', 'python-dev', 'serhiy.storchaka', 'Alex.Willmer', 'yan12125']
pr_nums = ['552']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue26944'
versions = ['Python 3.6', 'Python 3.7']

[xdegaye]

test_posix fails on an android emulator running an x86 system image at API level 21.

On android we have instead of a list of group IDs:
root@generic_x86:/data/local/tmp # id -G
uid=0(root) gid=0(root) groups=1003(graphics),1004(input),1007(log),1011(adb),1015(sdcard_rw),1028(sdcard_r),3001(net_bt_admin),3002(net_bt),3003(inet),3006(net_bw_stats) context=u:r:su:s0

======================================================================
ERROR: test_getgroups (test.test_posix.PosixTester)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/sdcard/org.bitbucket.pyona/lib/python3.6/test/test_posix.py", line 815, in test_getgroups
    set([int(x) for x in groups.split()]),
  File "/sdcard/org.bitbucket.pyona/lib/python3.6/test/test_posix.py", line 815, in <listcomp>
    set([int(x) for x in groups.split()]),
ValueError: invalid literal for int() with base 10: 'uid=0(root)'

---

Ran 83 tests in 0.114s

FAILED (errors=1, skipped=11)
test test_posix failed
1 test failed:
test_posix
Total duration: 0:00:01

[serhiy-storchaka]

See more information in comments in bpo-26932. Since the id tool looks fixed in Android 6.x we should skip the test on Android <6.x.

[xdegaye]

'id -G' produces the expected result on an android-23-x86 emulator running Android 6.0 (API 23).

There is a new error now instead of the one reported at issue bpo-26932:

======================================================================
FAIL: test_getgroups (test.test_posix.PosixTester)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/sdcard/org.bitbucket.pyona/lib/python3.6/test/test_posix.py", line 816, in test_getgroups
    set(posix.getgroups() + [posix.getegid()]))
AssertionError: Items in the second set but not the first:
0

The problem is that posix.getegid() returns 0, and 0 is not in the list printed by 'id -G'.

[xdegaye]

test_getgroups is ok on an android emulator running API 23 with the attached patch, and the test is skipped when running API 21.

[xdegaye]

New patch with cosmetic changes.

[larryhastings]

Is there a plan to make Android a supported platform in 3.6?

[xdegaye]

Is there a plan to make Android a supported platform in 3.6?

Answer in the Android meta-issue at msg 270942.

[vstinner]

ValueError: invalid literal for int() with base 10: 'uid=0(root)'

Hum, does the id program supports -G on Android? The output looks like the regular id output (without -G). Example on my Linux (Fedora 24):

$ id
uid=1000(haypo) gid=1000(haypo) groupes=1000(haypo),10(wheel) contexte=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023

$ id -G
1000 10