Change the decode_data default in smtpd to False

[serhiy-storchaka]

BPO	27033
Nosy	@warsaw, @vstinner, @bitdancer, @serhiy-storchaka, @soltysh, @zvyn
Files	smtpd_decode_data_false.patch smtpd_decode_data_false_doc.patch smtpd_decode_data_false_doc2.patch smtpd_decode_data_false_doc3.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2016-06-23.14:47:06.282>
created_at = <Date 2016-05-15.19:20:39.421>
labels = ['type-feature', 'library', 'expert-email']
title = 'Change the decode_data default in smtpd to False'
updated_at = <Date 2016-06-23.14:47:06.280>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2016-06-23.14:47:06.280>
actor = 'r.david.murray'
assignee = 'none'
closed = True
closed_date = <Date 2016-06-23.14:47:06.282>
closer = 'r.david.murray'
components = ['Library (Lib)', 'email']
creation = <Date 2016-05-15.19:20:39.421>
creator = 'serhiy.storchaka'
dependencies = []
files = ['42865', '42876', '43050', '43051']
hgrepos = []
issue_num = 27033
keywords = ['patch']
message_count = 16.0
messages = ['265645', '265671', '265694', '265695', '265716', '265725', '266625', '266626', '266633', '266634', '266637', '266638', '266639', '266640', '269027', '269115']
nosy_count = 14.0
nosy_names = ['barry', 'richard', 'vstinner', 'Arfrever', 'r.david.murray', 'jesstess', 'python-dev', 'serhiy.storchaka', 'maciej.szulik', 'lpolzer', 'Illirgway', 'Duke.Dougal', 'zvyn', 'sreepriya']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue27033'
versions = ['Python 3.6']

[serhiy-storchaka]

Proposed patch changes the default value of the decode_data parameter for smtpd.SMTPChannel and smtpd.SMTPServer constructors. The default value True was deprecated since adding this parameter in bpo-19662.

[python-dev]

New changeset a31b9f353346 by Serhiy Storchaka in branch 'default':
Issue bpo-27033: The default value of the decode_data parameter for
https://hg.python.org/cpython/rev/a31b9f353346

[bitdancer]

Um, I changed to to commit review because I was planning to review it. I don't expect to find any problems, but I'm surprised you committed it.

There does need to be a whatsnew entry, and specifically something in the porting section, since this is a behavior change.

[warsaw]

aiosmtpd already defaults decode_data to False. We should consider pulling this into 3.6 (not just for this reason of course).

http://aiosmtpd.readthedocs.io/en/latest/

[serhiy-storchaka]

Oh, sorry, I understood this as a sign that you already made a review and don't have comments. I was surprised that you made this silently.

Here is a patch that adds an entry in the porting section of What's New. Please also check changes in the smtpd documentation. I reformulated some sentences.

[bitdancer]

No problem. I use 'commit review' as an indication that a committer should do a final review...before that, triage or general community people can be doing the reviews, then triage can move it to commit review to request the final review before commit. What this means in practical terms is that if I do a search for 'email' issues in 'commit review' stage, I find all the issues I should be reviewing.

I'll try to do the review soon.

[serhiy-storchaka]

Thank you for your review David. Updated patch addresses your doc comments.

As for bool calls, I think there are reasons to do this.

[serhiy-storchaka]

Addressed other David's comment.

[bitdancer]

What reasons? It's not a big deal, but like I say it isn't our normal style.

[bitdancer]

Oh, I forgot to say that the revisions look good to me.