Tools/importbench/importbench.py is broken

[serhiy-storchaka]

BPO	27418
Nosy	@brettcannon, @serhiy-storchaka
Files	importbench.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2016-06-30.07:36:02.557>
created_at = <Date 2016-06-29.18:27:40.683>
labels = ['type-bug']
title = 'Tools/importbench/importbench.py is broken'
updated_at = <Date 2016-06-30.07:36:02.557>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2016-06-30.07:36:02.557>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2016-06-30.07:36:02.557>
closer = 'serhiy.storchaka'
components = ['Demos and Tools']
creation = <Date 2016-06-29.18:27:40.683>
creator = 'serhiy.storchaka'
dependencies = []
files = ['43583']
hgrepos = []
issue_num = 27418
keywords = ['patch']
message_count = 7.0
messages = ['269539', '269541', '269543', '269552', '269553', '269557', '269561']
nosy_count = 3.0
nosy_names = ['brett.cannon', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue27418'
versions = ['Python 3.5', 'Python 3.6']

[serhiy-storchaka]

$ ./python Tools/importbench/importbench.py
Traceback (most recent call last):
  File "Tools/importbench/importbench.py", line 8, in <module>
    from test.test_importlib.source import util as source_util
ImportError: cannot import name 'util'

[brettcannon]

If you don't have any use for it I say just delete the benchmark.

[serhiy-storchaka]

Just now I'm writing a patch for optimizing __import__. Maybe importbench would be helpful.

[brettcannon]

Feel free to do whatever you need/want to with the benchmark. I originally created it when switching __import__ to importlib to prove that it didn't impact performance.

[serhiy-storchaka]

Following patch seems fixes importbench.

[brettcannon]

I don't see anything obviously wrong with it.

[python-dev]

New changeset ba4548916f05 by Serhiy Storchaka in branch '3.5':
Issue bpo-27418: Fixed Tools/importbench/importbench.py.
https://hg.python.org/cpython/rev/ba4548916f05

New changeset c2e898813409 by Serhiy Storchaka in branch 'default':
Issue bpo-27418: Fixed Tools/importbench/importbench.py.
https://hg.python.org/cpython/rev/c2e898813409