Deprecate sys._mercurial and create sys._git

[brettcannon]

BPO	27593
Nosy	@brettcannon, @vstinner, @larryhastings, @benjaminp, @ned-deily, @zooba, @matrixise
PRs	bpo-27593: Updates Windows build to use information from git #262 bpo-27593: Get SCM build info from git instead of hg. #446 bpo-27593: Updates Windows build to use information from git (#262) #448 bpo-27593: Updates Windows build to use information from git (#262) #449 bpo-27593: Updates Windows build to use information from git (#262) #450 bpo-27593: Fixes git command #451 [3.6] bpo-27593: Get SCM build info from git instead of hg. (#446) #454 [3.5] bpo-27593: Get SCM build info from git instead of hg. (#446) #455 bpo-27593: Revise git SCM build info. #744 [3.6] bpo-27593: Revise git SCM build info. (#744) #745 [3.5] bpo-27593: Revise git SCM build info. (#744) #746 bpo-27593: Get SCM build info from git instead of hg #1327 bpo-27593: Revise git SCM build info. (#744) (#746) #1392
Files	issue27593.diff issue27593-with-indent-3.7.diff issue27593-with-indent-3.7-2.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/ned-deily'
closed_at = <Date 2017-05-02.16:32:17.680>
created_at = <Date 2016-07-22.21:43:25.488>
labels = ['3.7', 'library']
title = 'Deprecate sys._mercurial and create sys._git'
updated_at = <Date 2017-05-02.20:52:09.301>
user = 'https://github.com/brettcannon'

bugs.python.org fields:

activity = <Date 2017-05-02.20:52:09.301>
actor = 'vstinner'
assignee = 'ned.deily'
closed = True
closed_date = <Date 2017-05-02.16:32:17.680>
closer = 'brett.cannon'
components = ['Library (Lib)']
creation = <Date 2016-07-22.21:43:25.488>
creator = 'brett.cannon'
dependencies = []
files = ['44535', '45152', '45154']
hgrepos = []
issue_num = 27593
keywords = ['patch']
message_count = 46.0
messages = ['271037', '275524', '275525', '275544', '275671', '275825', '275831', '279037', '279044', '279045', '279046', '287715', '287725', '288490', '288574', '288719', '288771', '288950', '288964', '288965', '288966', '288967', '288988', '288994', '289911', '289943', '290121', '290125', '290126', '290127', '290299', '290305', '290307', '290309', '290310', '290311', '290312', '290600', '290610', '290626', '292461', '292772', '292778', '292785', '292801', '292805']
nosy_count = 7.0
nosy_names = ['brett.cannon', 'vstinner', 'larry', 'benjamin.peterson', 'ned.deily', 'steve.dower', 'matrixise']
pr_nums = ['262', '446', '448', '449', '450', '451', '454', '455', '744', '745', '746', '1327', '1392']
priority = 'high'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue27593'
versions = ['Python 2.7', 'Python 3.5', 'Python 3.6', 'Python 3.7']

[brettcannon]

This is part of the GitHub migration. And by "deprecate" sys._mercurial I mean fill it with default values (https://www.python.org/dev/peps/pep-0512/#deprecate-sys-mercurial).

[brettcannon]

Get the current branch: git rev-parse --abbrev-ref HEAD

[brettcannon]

Get the current revision: git rev-parse HEAD

[brettcannon]

https://github.com/python/cpython/blob/master/Modules/getbuildinfo.c will need to be updated on top of configure.ac and Makefile.pre.in.

[brettcannon]

Here is a patch to add sys._git and update Py_GetBuildInfo() as necessary. I would like to see this in Python 3.6 as 3.6.0 will be released using Mercurial but (hopefully) subsequent releases will be on git, so any reviews will be appreciated.

I will hold off on removing sys._mercurial until 3.7 as that will be the first release that doesn't span version control systems.

[ned-deily]

Thanks for the patch, Brett. Having done a quick test, I'd like to review this in more detail before applying but that will have to wait until after b1. If you want, you can reassign this to me.

[brettcannon]

Sounds good.

On Sun, Sep 11, 2016, 11:13 Ned Deily <report@bugs.python.org> wrote:

Ned Deily added the comment:

Thanks for the patch, Brett. Having done a quick test, I'd like to review
this in more detail before applying but that will have to wait until after
b1. If you want, you can reassign this to me.

----------
priority: release blocker -> deferred blocker
stage: -> patch review
versions: +Python 3.7

---

Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue27593\>

---

[matrixise]

Hello Brett,

after my review, I propose this patch where I have added the missing indents and remove the ./configure file (because this one can be generated by autoreconf)

[brettcannon]

The inclusion of changes to ./configure is on purpose since the file is in the repository and not everyone has autoconf installed to necessarily re-generate the file (and we have had issues with people using really old versions of autoconf in the past).