Avoid ResourceWarnings from platform._dist_try_harder

[scop]

BPO	27903
Nosy	@malemburg, @vstinner, @scop, @miss-islington, @tirkarthi
PRs	[3.7] bpo-27903: Fix ResourceWarning in platform.dist() #10792 [3.6] bpo-27903: Fix ResourceWarning in platform.dist() (GH-10792) #10793
Files	platform-resourcewarning.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-11-29.12:04:41.868>
created_at = <Date 2016-08-30.21:19:38.283>
labels = ['3.7', 'type-feature', 'library']
title = 'Avoid ResourceWarnings from platform._dist_try_harder'
updated_at = <Date 2018-11-29.12:08:48.629>
user = 'https://github.com/scop'

bugs.python.org fields:

activity = <Date 2018-11-29.12:08:48.629>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2018-11-29.12:04:41.868>
closer = 'vstinner'
components = ['Library (Lib)']
creation = <Date 2016-08-30.21:19:38.283>
creator = 'scop'
dependencies = []
files = ['44283']
hgrepos = []
issue_num = 27903
keywords = ['patch']
message_count = 9.0
messages = ['273969', '326338', '330662', '330680', '330681', '330682', '330683', '330684', '330685']
nosy_count = 5.0
nosy_names = ['lemburg', 'vstinner', 'scop', 'miss-islington', 'xtreak']
pr_nums = ['10792', '10793']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue27903'
versions = ['Python 3.6', 'Python 3.7']

[scop]

Use opened files as context managers.

[tirkarthi]

Thanks for the report and patch Ville. CPython development now uses GitHub PR instead of patches. It seems usages of this function was removed in 8b94b41 during removal of platform.linux_distribution. This essentially seems to be unused code on master which I hope can be removed. So this patch is effective only for 3.7 and 3.6. Would you like to make a PR to take this forward?

No usages on master except definition.

➜ cpython git:(master) rg _dist_try_harder
Lib/platform.py
230:def _dist_try_harder(distname, version, id):

Thanks

[tirkarthi]

I guess this can be closed as out of date since the function was removed with #10787.

cc: Victor

[vstinner]

Python 3.6 and 3.7 are still supported. The patch LGTM, I converted it to a PR.

[vstinner]

New changeset 7eeab87 by Victor Stinner in branch '3.7':
bpo-27903: Fix ResourceWarning in platform.dist() (GH-10792)
7eeab87

[miss-islington]

New changeset cbf5767 by Miss Islington (bot) in branch '3.6':
bpo-27903: Fix ResourceWarning in platform.dist() (GH-10792)
cbf5767

[vstinner]

Thanks Ville Skyttä for your bugfix! I applied it in 3.6 and 3.7 branches.

FYI as Karthikeyan Singaravelan wrote, the function is gone (I removed it) from the master branch ;-)

[tirkarthi]

Ah sorry I forgot the previous versions that had this code. Thanks for the catch and PR victor :)

[vstinner]

No problem, thanks for "cc-ing" me ;-)