gzip does not support pathlib

[ethanfurman]

BPO	28227
Nosy	@brettcannon, @ned-deily, @ethanfurman, @berkerpeksag, @serhiy-storchaka
PRs	[Do Not Merge] Convert Misc/NEWS so that it is managed by towncrier #552
Files	open-gzip.stoneleaf.patch issue28227_v2.diff issue28227_v3.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/berkerpeksag'
closed_at = <Date 2016-10-02.10:47:36.007>
created_at = <Date 2016-09-21.07:29:26.835>
labels = ['type-bug', '3.7']
title = 'gzip does not support pathlib'
updated_at = <Date 2017-03-31.16:36:14.045>
user = 'https://github.com/ethanfurman'

bugs.python.org fields:

activity = <Date 2017-03-31.16:36:14.045>
actor = 'dstufft'
assignee = 'berker.peksag'
closed = True
closed_date = <Date 2016-10-02.10:47:36.007>
closer = 'berker.peksag'
components = []
creation = <Date 2016-09-21.07:29:26.835>
creator = 'ethan.furman'
dependencies = []
files = ['44769', '44926', '44927']
hgrepos = []
issue_num = 28227
keywords = ['patch']
message_count = 8.0
messages = ['277110', '277865', '277876', '277879', '277881', '277883', '277884', '277885']
nosy_count = 6.0
nosy_names = ['brett.cannon', 'ned.deily', 'ethan.furman', 'python-dev', 'berker.peksag', 'serhiy.storchaka']
pr_nums = ['552']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue28227'
versions = ['Python 3.6', 'Python 3.7']

[serhiy-storchaka]

Since patches for gzip, bz2 and lzma are too similar, I think it is worth to merge them in one patch.

[berkerpeksag]

I've addressed all of Serhiy's review comments. Thanks!

[serhiy-storchaka]

You missed one my comment. GzipFile.name is not converted in write mode.

[berkerpeksag]

You're right. I definitely missed that one. Here is an updated patch. Thanks again!

[berkerpeksag]

By the way, for some reason it doesn't show up at https://bugs.python.org/review/28227/patch/18629/74286

[serhiy-storchaka]

The patch LGTM.

[python-dev]

New changeset 3f71d1a93053 by Berker Peksag in branch '3.6':
Issue bpo-28227: gzip now supports pathlib
https://hg.python.org/cpython/rev/3f71d1a93053

New changeset b244bf74b638 by Berker Peksag in branch 'default':
Issue bpo-28227: Merge from 3.6
https://hg.python.org/cpython/rev/b244bf74b638

[berkerpeksag]

Thanks Ethan and Serhiy.