imghdr does not support pathlib

[ethanfurman]

BPO	28228
Nosy	@brettcannon, @ned-deily, @ethanfurman, @berkerpeksag, @serhiy-storchaka, @4simple-org
PRs	[Do Not Merge] Convert Misc/NEWS so that it is managed by towncrier #552
Files	open-imghdr.stoneleaf.patch issue28228_v2.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/berkerpeksag'
closed_at = <Date 2016-10-01.02:08:57.104>
created_at = <Date 2016-09-21.07:30:06.728>
labels = ['3.7', 'type-bug', 'library']
title = 'imghdr does not support pathlib'
updated_at = <Date 2017-03-31.16:36:13.498>
user = 'https://github.com/ethanfurman'

bugs.python.org fields:

activity = <Date 2017-03-31.16:36:13.498>
actor = 'dstufft'
assignee = 'berker.peksag'
closed = True
closed_date = <Date 2016-10-01.02:08:57.104>
closer = 'berker.peksag'
components = ['Library (Lib)']
creation = <Date 2016-09-21.07:30:06.728>
creator = 'ethan.furman'
dependencies = []
files = ['44770', '44884']
hgrepos = []
issue_num = 28228
keywords = ['patch']
message_count = 10.0
messages = ['277182', '277183', '277301', '277728', '277732', '277768', '277776', '277788', '277789', '279945']
nosy_count = 7.0
nosy_names = ['brett.cannon', 'ned.deily', 'ethan.furman', 'python-dev', 'berker.peksag', 'serhiy.storchaka', '4simple-org']
pr_nums = ['552']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue28228'
versions = ['Python 3.6', 'Python 3.7']

[ethanfurman]

Supporting pathlib was one of the requirements of removing the provisional status. Why have you changed the type to enhancement?

[brettcannon]

"Removing the provisional status" of what? Pathlib? If so, have you asked Ned if adding support during the beta period is acceptable? This open question is probably why Serhiy changed the type as without Ned's sign-off it means changing something in the stdlib for __fspath__() support is an enhancement and thus needs to be a 3.7 thing. But if Ned allows for classifying the lack of support as a bug then you could classify this a behaviour problem.

I personally view it as an enhancement, but one that we should try to land prior to RC if Ned is okay with that.

[ned-deily]

Since better pathlib support in standard library modules has been a focus of 3.6, I'm willing to allow this and the related changes for gzip, tarfile, zipfile, bz2, lzma, and compilall (bpo-28225 through bpo-28231) if thay introduce no backward incompatibilities, are reviewed, and are pushed in time for 360b2.

[brettcannon]

According to https://www.python.org/dev/peps/pep-0494/#schedule, 2.6.0b2 is due on Sunday. Do you think you will be able to commit this and the other patches for PathLike support by then, Ethan?

[berkerpeksag]

Here's a new patch that addresses Serhiy's comments.

Let me know if you need a hand with review and commit these patches this weekend :)

[ethanfurman]

Berker, yes please. I just got back from vacation.

[brettcannon]

Berker, your patch LGTM

[python-dev]

New changeset 929e3adefe7a by Berker Peksag in branch '3.6':
Issue bpo-28228: imghdr now supports pathlib
https://hg.python.org/cpython/rev/929e3adefe7a

New changeset 013b3b5d3b6c by Berker Peksag in branch 'default':
Issue bpo-28228: Merge from 3.6
https://hg.python.org/cpython/rev/013b3b5d3b6c

[berkerpeksag]

Thanks for the review, Brett!

The next target is gzip module. Thanks for the all patches Ethan :)