cannot set_inheritable() for a file descriptor on Android

[xdegaye]

BPO	28746
Nosy	@xdegaye
PRs	[Do Not Merge] Convert Misc/NEWS so that it is managed by towncrier #552
Files	set_inheritable.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/xdegaye'
closed_at = <Date 2016-11-19.16:35:49.474>
created_at = <Date 2016-11-19.14:19:33.298>
labels = ['interpreter-core', 'type-bug', '3.7']
title = 'cannot set_inheritable() for a file descriptor on Android'
updated_at = <Date 2017-03-31.16:36:10.597>
user = 'https://github.com/xdegaye'

bugs.python.org fields:

activity = <Date 2017-03-31.16:36:10.597>
actor = 'dstufft'
assignee = 'xdegaye'
closed = True
closed_date = <Date 2016-11-19.16:35:49.474>
closer = 'xdegaye'
components = ['Interpreter Core']
creation = <Date 2016-11-19.14:19:33.298>
creator = 'xdegaye'
dependencies = []
files = ['45547']
hgrepos = []
issue_num = 28746
keywords = ['patch']
message_count = 3.0
messages = ['281221', '281222', '281224']
nosy_count = 2.0
nosy_names = ['xdegaye', 'python-dev']
pr_nums = ['552']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue28746'
versions = ['Python 3.6', 'Python 3.7']

[xdegaye]

test_socket on Android fails with:
FAIL: test_set_inheritable (test.test_socket.InheritanceTest)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/sdcard/org.bitbucket.pyona/lib/python3.7/test/test_socket.py", line 4936, in test_set_inheritable
    self.assertEqual(sock.get_inheritable(), True)
AssertionError: False != True

======================================================================
FAIL: test_set_inheritable_cloexec (test.test_socket.InheritanceTest)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/sdcard/org.bitbucket.pyona/lib/python3.7/test/test_socket.py", line 4965, in test_set_inheritable_cloexec
    0)
AssertionError: 1 != 0

Setting a file descriptor with os.set_inheritable() also fails.
Setting directly the file descriptor with fcntl.fcntl() succeeds.

[xdegaye]

It seems the code path run by Android is not tested by any of the buildbots.
Patch attached.

[python-dev]

New changeset 2fb2e3dc450e by Xavier de Gaye in branch '3.6':
Issue bpo-28746: Fix the set_inheritable() file descriptor method on platforms
https://hg.python.org/cpython/rev/2fb2e3dc450e

New changeset 3248782c3176 by Xavier de Gaye in branch 'default':
Issue bpo-28746: Merge 3.6
https://hg.python.org/cpython/rev/3248782c3176