Update python-gdb.py for fastcalls

[vstinner]

BPO	28770
Nosy	@vstinner, @ned-deily, @methane
Files	gdb_fastcall.patch gdb_fastcall-2.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2016-12-17.05:09:56.782>
created_at = <Date 2016-11-22.11:42:55.134>
labels = ['3.7']
title = 'Update python-gdb.py for fastcalls'
updated_at = <Date 2016-12-17.05:09:56.780>
user = 'https://github.com/vstinner'

bugs.python.org fields:

activity = <Date 2016-12-17.05:09:56.780>
actor = 'ned.deily'
assignee = 'none'
closed = True
closed_date = <Date 2016-12-17.05:09:56.782>
closer = 'ned.deily'
components = []
creation = <Date 2016-11-22.11:42:55.134>
creator = 'vstinner'
dependencies = []
files = ['45598', '45599']
hgrepos = []
issue_num = 28770
keywords = ['patch']
message_count = 10.0
messages = ['281465', '281522', '281523', '282603', '282715', '282716', '283402', '283407', '283464', '283467']
nosy_count = 4.0
nosy_names = ['vstinner', 'ned.deily', 'methane', 'python-dev']
pr_nums = []
priority = None
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue28770'
versions = ['Python 3.6', 'Python 3.7']

[vstinner]

Python 3.6 has a new C calling convention: "fast calls".

python-gdb.py was disabled when compact dict was merged, see issue bpo-27350.

Sadly, I missed that fast calls also broke python-gdb.py.

Attached patch fixes python-gdb.py, but I failed to fix test_gdb.py. With fast calls and patched python-gdb.py, python-gdb.py is now able to detect the Python frame of the call to the builtin id() function. It's a new feature compared to Python 3.5, but test_gdb.py should be updated to handle that.

I will try to fix that later, but in the meanwhile I was interrupted because the fix for compact dict in python-gdb.py failed on buildbots, see:
http://bugs.python.org/issue28023#msg281464

[python-dev]

New changeset 752863f96fb8 by Victor Stinner in branch 'default':
Issue bpo-28770: Update python-gdb.py for fastcalls
https://hg.python.org/cpython/rev/752863f96fb8

[vstinner]

I keep the issue open until the 3.6 branch is reopened for regular bug fixes, like this one. Then I will backport the fix to 3.6.

[methane]

3.6 branch is reopened

[python-dev]

New changeset f41d02d7da37 by Victor Stinner in branch '3.6':
Issue bpo-28770: Update python-gdb.py for fastcalls
https://hg.python.org/cpython/rev/f41d02d7da37

[vstinner]

I fixed the issue in Python 3.6 (future 3.6.1).

[vstinner]

The change was cherry-picked in Python 3.6.0RC2.

The issue is now fixed, so I close the issue.

[ned-deily]

Please leave this open until the cherry picking is completed.

[python-dev]

New changeset b0efa88c4cf4 by Victor Stinner in branch '3.6':
Issue bpo-28770: Update python-gdb.py for fastcalls
https://hg.python.org/cpython/rev/b0efa88c4cf4