Out of tree --with--dtrace builds fail with a traceback

[stratakis]

BPO	28787
Nosy	@vstinner, @cburroughs, @stratakis
PRs	bpo-28787: Fix out of tree --with-dtrace builds #135 [3.6] bpo-28787: Fix out of tree --with-dtrace builds #1519 [3.6] bpo-28787: Fix out of tree --with-dtrace builds (GH-135) #1543
Files	create-Include-dir-to-properly-generate-pydtrace_probes.h-file.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2017-05-11.11:13:53.920>
created_at = <Date 2016-11-24.10:10:45.616>
labels = ['build', '3.7']
title = 'Out of tree --with--dtrace builds fail with a traceback'
updated_at = <Date 2017-05-11.11:13:53.918>
user = 'https://github.com/stratakis'

bugs.python.org fields:

activity = <Date 2017-05-11.11:13:53.918>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2017-05-11.11:13:53.920>
closer = 'vstinner'
components = ['Build']
creation = <Date 2016-11-24.10:10:45.616>
creator = 'cstratak'
dependencies = []
files = ['45622']
hgrepos = []
issue_num = 28787
keywords = ['patch']
message_count = 4.0
messages = ['281627', '293425', '293487', '293488']
nosy_count = 3.0
nosy_names = ['vstinner', 'cburroughs', 'cstratak']
pr_nums = ['135', '1519', '1543']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue28787'
versions = ['Python 3.6', 'Python 3.7']

[stratakis]

By invoking an out of tree build of python with the --with-dtrace flag enabled, make fails with an error.

Create a new folder at the source directory:
$ mkdir _build && cd _build
$ ../configure --with-dtrace
$ make

/usr/bin/dtrace  -o Include/pydtrace_probes.h -h -s ../Include/pydtrace.d
Traceback (most recent call last):
  File "/usr/bin/dtrace", line 440, in <module>
    sys.exit(main())
  File "/usr/bin/dtrace", line 385, in main
    providers.probe_write(s_filename, filename + suffix)
  File "/usr/bin/dtrace", line 181, in probe_write
    hdr = open(header, mode='w')
FileNotFoundError: [Errno 2] No such file or directory: 'Include/pydtrace_probes.h'
Makefile:896: recipe for target 'Include/pydtrace_probes.h' failed
make: *** [Include/pydtrace_probes.h] Error 1

This is because the Include directory doesn't exist.

Attaching a patch to fix this.

[vstinner]

New changeset f6eae5b by Victor Stinner (stratakis) in branch 'master':
bpo-28787: Fix out of tree --with-dtrace builds (#135)
f6eae5b

[vstinner]

New changeset a4465a5 by Victor Stinner (stratakis) in branch '3.6':
[3.6] bpo-28787: Fix out of tree --with-dtrace builds (GH-135) (bpo-1543)
a4465a5

[vstinner]

Thank you Charalampos, I merged your fixes for branches 3.6 and master (3.7).