--enable-optimizations compiler flag has no effect

[aw1621107]

BPO	29643
Nosy	@vstinner, @methane, @aw1621107
PRs	bpo-29643: Fix check for --enable-optimizations #129 [3.6] bpo-29643: Fix check for --enable-optimizations #869 bpo-29643: Fix check for --enable-optimizations (GH-129) #870 [3.5] bpo-29643: Fix check for --enable-optimizations #871 [2.7] bpo-29643: Fix check for --enable-optimizations #873

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2017-03-28.16:51:50.888>
created_at = <Date 2017-02-24.23:20:10.836>
labels = ['type-bug', '3.7', 'build']
title = '--enable-optimizations compiler flag has no effect'
updated_at = <Date 2017-03-28.16:51:50.887>
user = 'https://github.com/aw1621107'

bugs.python.org fields:

activity = <Date 2017-03-28.16:51:50.887>
actor = 'methane'
assignee = 'none'
closed = True
closed_date = <Date 2017-03-28.16:51:50.888>
closer = 'methane'
components = ['Build']
creation = <Date 2017-02-24.23:20:10.836>
creator = 'awang'
dependencies = []
files = []
hgrepos = []
issue_num = 29643
keywords = []
message_count = 7.0
messages = ['288535', '288536', '288537', '290705', '290730', '290731', '290741']
nosy_count = 3.0
nosy_names = ['vstinner', 'methane', 'awang']
pr_nums = ['129', '869', '870', '871', '873']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue29643'
versions = ['Python 2.7', 'Python 3.5', 'Python 3.6', 'Python 3.7']

[aw1621107]

PR submitted here: #129

[vstinner]

The flag has an effect, I tested it today ;-)

Can you please elaborate why you consider that the flag has no effect?

[aw1621107]

At least when I last built Python, configure always said that optimizations were not enabled regardless of whether I passed in the flag.

From what it looked like to me, it's because configure uses the $enableval variable to store the result of the check for --enable-optimizations, but the script checks $withval

[methane]

New changeset 8cea592 by INADA Naoki (Alex Wang) in branch 'master':
bpo-29643: Fix check for --enable-optimizations (GH-129)
8cea592

[methane]

New changeset f01de61 by INADA Naoki in branch '3.6':
bpo-29643: Fix check for --enable-optimizations (GH-869)
f01de61

[methane]

New changeset e6a4953 by INADA Naoki in branch '3.5':
bpo-29643: Fix check for --enable-optimizations (GH-871)
e6a4953

[methane]

New changeset 6a04ef7 by INADA Naoki in branch '2.7':
bpo-29643: Fix check for --enable-optimizations (GH-873)
6a04ef7