_PyCode_SetExtra behaviour wrong on allocation failure and after realloc

[brianfcoleman]

BPO	29683
Nosy	@vstinner, @serhiy-storchaka, @brianfcoleman
PRs	bpo-29683 - Fixes to _PyCode_SetExtra when co_extra->ce->extras is allocated #376 [3.6] bpo-29683 - Fixes to _PyCode_SetExtra when co_extra->ce->extras is allocated. #402 [Do Not Merge] Sample of CPython life with blurb. #703 [Do Not Merge] Convert Misc/NEWS so that it is managed by towncrier #552

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2017-03-03.05:35:28.233>
created_at = <Date 2017-03-01.08:52:12.857>
labels = ['interpreter-core', '3.7', 'performance']
title = '_PyCode_SetExtra behaviour wrong on allocation failure and after realloc'
updated_at = <Date 2017-03-31.16:36:12.804>
user = 'https://github.com/brianfcoleman'

bugs.python.org fields:

activity = <Date 2017-03-31.16:36:12.804>
actor = 'dstufft'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2017-03-03.05:35:28.233>
closer = 'serhiy.storchaka'
components = ['Interpreter Core']
creation = <Date 2017-03-01.08:52:12.857>
creator = 'brianfcoleman'
dependencies = []
files = []
hgrepos = []
issue_num = 29683
keywords = []
message_count = 6.0
messages = ['288745', '288747', '288833', '288858', '290341', '290348']
nosy_count = 3.0
nosy_names = ['vstinner', 'serhiy.storchaka', 'brianfcoleman']
pr_nums = ['376', '402', '703', '552']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'resource usage'
url = 'https://bugs.python.org/issue29683'
versions = ['Python 3.6', 'Python 3.7']

[brianfcoleman]

On PyMem_Malloc failure, _PyCode_SetExtra should set co_extra->ce_size = 0.
On PyMem_Realloc failure, _PyCode_SetExtra should set co_extra->ce_size = 0.
On PyMem_Realloc success, _PyCode_SetExtra should set all unused slots in co_extra->ce_extras to NULL.

I will add a GitHub PR for this shortly.

[brianfcoleman]

I have now added a Github pull request here:
#376

[brianfcoleman]

I have created a pull request to backport the fix onto 3.6 here:
#402

[serhiy-storchaka]

Thank you for your contribution Brian.

[serhiy-storchaka]

New changeset a6e8493 by Serhiy Storchaka (Brian Coleman) in branch '3.6':
bpo-29683 - Fixes to _PyCode_SetExtra when co_extra->ce->extras is (#402)
a6e8493

[vstinner]

New changeset 6a9122c by Victor Stinner (Brian Coleman) in branch 'master':
bpo-29683 - Fixes to _PyCode_SetExtra when co_extra->ce->extras is (#376)
6a9122c