IDLE: Config dialog again deletes custom themes and keysets.

[terryjreedy]

BPO	31502
Nosy	@terryjreedy
PRs	bpo-31502: IDLE Configdialog again deletes custom themes and keysets. #3634 [3.6] bpo-31502: IDLE Configdialog again deletes custom themes and keysets. (GH-3634) #3636

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2017-09-22.18:03:37.523>
created_at = <Date 2017-09-17.23:11:45.060>
labels = ['expert-IDLE', 'type-bug', '3.7']
title = 'IDLE: Config dialog again deletes custom themes and keysets.'
updated_at = <Date 2017-09-22.18:03:37.522>
user = 'https://github.com/terryjreedy'

bugs.python.org fields:

activity = <Date 2017-09-22.18:03:37.522>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2017-09-22.18:03:37.523>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2017-09-17.23:11:45.060>
creator = 'terry.reedy'
dependencies = []
files = []
hgrepos = []
issue_num = 31502
keywords = ['patch']
message_count = 4.0
messages = ['302392', '302393', '302396', '302400']
nosy_count = 1.0
nosy_names = ['terry.reedy']
pr_nums = ['3634', '3636']
priority = 'high'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue31502'
versions = ['Python 3.6', 'Python 3.7']

[terryjreedy]

The askyesno messagebox wrappers, added in bpo-31287, returned None, which is interpreted as 'No', instead of the user entry. With 'Yes' not seen, nothing was saved.

The manual tests, once the problem was understood, is to save a new theme/keyset and click the delete button twice, clicking No the first time and Yes the second time, and see what happens.

Unit testing the current version of askyesno would be difficult since it calls messagebox.askyesno(), which returns an answer, and there is no obvious way to get a reference to the actual widget, in order to generate simulated key or click events.

A long term solution might be to add a new subclass to query.Query, after reviewing *it* for ease of testing.

[terryjreedy]

I am not adding a new item because the regression has not been released.

[terryjreedy]

New changeset 0efc7c6 by Terry Jan Reedy in branch 'master':
bpo-31502: IDLE Configdialog again deletes custom themes and keysets. (bpo-3634)
0efc7c6

[terryjreedy]

New changeset 6b4d8ba by Terry Jan Reedy (Miss Islington (bot)) in branch '3.6':
[3.6] bpo-31502: IDLE Configdialog again deletes custom themes and keysets. (GH-3634) (bpo-3636)
6b4d8ba