Memory leak in the compiler in case of errors

[serhiy-storchaka]

BPO	34080
Nosy	@vstinner, @serhiy-storchaka, @miss-islington
PRs	bpo-34080: Fix a memory leak in the compiler. #8222 bpo-34080: Fix memory leak on parsing error #8242 [3.7] bpo-34080: Fix a memory leak in the compiler. (GH-8222) #8256 [3.6] bpo-34080: Fix a memory leak in the compiler. (GH-8222) #8257 [2.7] bpo-34080: Fix a memory leak in the compiler. (GH-8222) #8258

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2018-07-11.22:06:11.805>
created_at = <Date 2018-07-10.08:20:42.010>
labels = ['interpreter-core', '3.7', '3.8', 'performance']
title = 'Memory leak in the compiler in case of errors'
updated_at = <Date 2018-07-11.22:06:11.803>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2018-07-11.22:06:11.803>
actor = 'vstinner'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2018-07-11.22:06:11.805>
closer = 'vstinner'
components = ['Interpreter Core']
creation = <Date 2018-07-10.08:20:42.010>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 34080
keywords = ['patch']
message_count = 7.0
messages = ['321367', '321419', '321500', '321504', '321506', '321507', '321508']
nosy_count = 3.0
nosy_names = ['vstinner', 'serhiy.storchaka', 'miss-islington']
pr_nums = ['8222', '8242', '8256', '8257', '8258']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'resource usage'
url = 'https://bugs.python.org/issue34080'
versions = ['Python 2.7', 'Python 3.6', 'Python 3.7', 'Python 3.8']

[serhiy-storchaka]

Merging PR 6517 for bpo-33305 exposed a leak in the compiler:

https://buildbot.python.org/all/#/builders/1/builds/280

$ ./python -m test -R 3:3 test_compile test_grammar
Run tests sequentially
0:00:00 load avg: 1.95 [1/2] test_compile
beginning 6 repetitions
123456
......
test_compile leaked [15, 16, 15] memory blocks, sum=46
0:00:14 load avg: 1.97 [2/2/1] test_grammar -- test_compile failed
beginning 6 repetitions
123456
......
test_grammar leaked [50, 50, 50] memory blocks, sum=150
test_grammar failed

== Tests result: FAILURE ==

2 tests failed:
test_compile test_grammar

Total duration: 15 sec 226 ms
Tests result: FAILURE

This branch was not common, but after bpo-33305 it has became more common and heavily tested.

[vstinner]

Related issue: bpo-34084.

[vstinner]

New changeset 993030a by Victor Stinner (Serhiy Storchaka) in branch 'master':
bpo-34080: Fix a memory leak in the compiler. (GH-8222)
993030a

[miss-islington]

New changeset a45fa39 by Miss Islington (bot) in branch '2.7':
bpo-34080: Fix a memory leak in the compiler. (GH-8222)
a45fa39

[miss-islington]

New changeset 9beed0c by Miss Islington (bot) in branch '3.7':
bpo-34080: Fix a memory leak in the compiler. (GH-8222)
9beed0c

[vstinner]

New changeset 3b06285 by Victor Stinner (Miss Islington (bot)) in branch '3.6':
bpo-34080: Fix a memory leak in the compiler. (GH-8222) (GH-8257)
3b06285

[vstinner]

Thanks Serhiy for the fix! It seems that new tests helped to find a real bug ;-)