distutils._msvccompiler should trim INCLUDE/LIB directories

[zooba]

BPO	34225
Nosy	@pfmoore, @tjguk, @merwok, @zware, @zooba, @dstufft
PRs	bpo-34225: Ensure INCLUDE and LIB directories do not end with a backslash #8464 [3.7] bpo-34225: Ensure INCLUDE and LIB directories do not end with a backslash. (GH-8464) #8478 [3.6] bpo-34225: Ensure INCLUDE and LIB directories do not end with a backslash. (GH-8464) #8477

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/zooba'
closed_at = <Date 2018-07-26.16:19:24.254>
created_at = <Date 2018-07-25.14:54:28.322>
labels = ['3.8', '3.7', 'library', 'OS-windows']
title = 'distutils._msvccompiler should trim INCLUDE/LIB directories'
updated_at = <Date 2018-07-29.09:02:19.890>
user = 'https://github.com/zooba'

bugs.python.org fields:

activity = <Date 2018-07-29.09:02:19.890>
actor = 'steve.dower'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2018-07-26.16:19:24.254>
closer = 'steve.dower'
components = ['Distutils', 'Windows']
creation = <Date 2018-07-25.14:54:28.322>
creator = 'steve.dower'
dependencies = []
files = []
hgrepos = []
issue_num = 34225
keywords = ['patch']
message_count = 3.0
messages = ['322361', '322414', '322616']
nosy_count = 6.0
nosy_names = ['paul.moore', 'tim.golden', 'eric.araujo', 'zach.ware', 'steve.dower', 'dstufft']
pr_nums = ['8464', '8478', '8477']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue34225'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']

[zooba]

_msvccompiler reads the INCLUDE and LIB environment variables when building and adds each directory to the command line. However, if any of these end with os.sep (specifically, '\'), then it will escape the quoting and break the entire command.

We should rstrip(os.sep) on each item from this list.

[zooba]

New changeset 5473f06 by Steve Dower in branch 'master':
bpo-34225: Ensure INCLUDE and LIB directories do not end with a backslash. (GH-8464)
5473f06

[zooba]

New changeset 8f6a7e1 by Steve Dower (Miss Islington (bot)) in branch '3.6':
bpo-34225: Ensure INCLUDE and LIB directories do not end with a backslash. (GH-8464)
8f6a7e1