PyObject_Print() doesn't always return -1 on error

[ZackerySpytz]

BPO	34910
Nosy	@serhiy-storchaka, @ZackerySpytz, @miss-islington
PRs	bpo-34910: Ensure PyObject_Print() always returns -1 on error #9733 [3.7] bpo-34910: Ensure that PyObject_Print() always returns -1 on error. (GH-9733) #9739 [3.6] bpo-34910: Ensure that PyObject_Print() always returns -1 on error. (GH-9733) #9740

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-10-06.07:11:01.475>
created_at = <Date 2018-10-05.23:05:07.077>
labels = ['interpreter-core', '3.8', 'type-bug', '3.7']
title = "PyObject_Print() doesn't always return -1 on error"
updated_at = <Date 2018-10-06.07:11:01.473>
user = 'https://github.com/ZackerySpytz'

bugs.python.org fields:

activity = <Date 2018-10-06.07:11:01.473>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2018-10-06.07:11:01.475>
closer = 'serhiy.storchaka'
components = ['Interpreter Core']
creation = <Date 2018-10-05.23:05:07.077>
creator = 'ZackerySpytz'
dependencies = []
files = []
hgrepos = []
issue_num = 34910
keywords = ['patch']
message_count = 5.0
messages = ['327197', '327229', '327231', '327232', '327233']
nosy_count = 3.0
nosy_names = ['serhiy.storchaka', 'ZackerySpytz', 'miss-islington']
pr_nums = ['9733', '9739', '9740']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue34910'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']

[ZackerySpytz]

PyObject_Print() returns 0 if PyUnicode_AsEncodedString() fails.

[serhiy-storchaka]

New changeset ae62f01 by Serhiy Storchaka (Zackery Spytz) in branch 'master':
bpo-34910: Ensure that PyObject_Print() always returns -1 on error. (GH-9733)
ae62f01

[miss-islington]

New changeset 177254c by Miss Islington (bot) in branch '3.6':
bpo-34910: Ensure that PyObject_Print() always returns -1 on error. (GH-9733)
177254c

[miss-islington]

New changeset 49fb49d by Miss Islington (bot) in branch '3.7':
bpo-34910: Ensure that PyObject_Print() always returns -1 on error. (GH-9733)
49fb49d

[serhiy-storchaka]

Thank you Zackery for catching such kind of errors.