Coverity scan: copy/paste error in Lib/xml/dom/minidom.py

[stratakis]

BPO	35052
Nosy	@vstinner, @taleinat, @encukou, @serhiy-storchaka, @stratakis, @shivank98
PRs	bpo-35052: Fix handler on xml.dom.minidom.cloneNode() #11061 [3.7] bpo-35052: Fix handler on xml.dom.minidom.cloneNode() (GH-11061) #11066 [3.6] bpo-35052: Fix handler on xml.dom.minidom.cloneNode() (GH-11061) #11067 [2.7] bpo-35052: Fix handler on xml.dom.minidom.cloneNode() (GH-11061) #11068
Files	reproducer.py

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-12-10.10:58:45.003>
created_at = <Date 2018-10-23.15:30:54.302>
labels = ['expert-XML', '3.8', 'type-bug', 'library', '3.7']
title = 'Coverity scan: copy/paste error in Lib/xml/dom/minidom.py'
updated_at = <Date 2018-12-10.10:58:45.002>
user = 'https://github.com/stratakis'

bugs.python.org fields:

activity = <Date 2018-12-10.10:58:45.002>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2018-12-10.10:58:45.003>
closer = 'vstinner'
components = ['Library (Lib)', 'XML']
creation = <Date 2018-10-23.15:30:54.302>
creator = 'cstratak'
dependencies = []
files = ['47942']
hgrepos = []
issue_num = 35052
keywords = ['patch']
message_count = 28.0
messages = ['328321', '328330', '328431', '328432', '328433', '328434', '328435', '328439', '328440', '328467', '328479', '328483', '328485', '328608', '328609', '328611', '328612', '328613', '328906', '330072', '330301', '331476', '331477', '331484', '331490', '331492', '331493', '331494']
nosy_count = 6.0
nosy_names = ['vstinner', 'taleinat', 'petr.viktorin', 'serhiy.storchaka', 'cstratak', 'shivank98']
pr_nums = ['11061', '11066', '11067', '11068']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue35052'
versions = ['Python 2.7', 'Python 3.6', 'Python 3.7', 'Python 3.8']

[stratakis]

Analyzing some coverity scan results I stumbled upon this issue:

Python-3.6.5/Lib/xml/dom/minidom.py:1914: original: "n._call_user_data_handler(operation, n, notation)" looks like the original copy.
Python-3.6.5/Lib/xml/dom/minidom.py:1924: copy_paste_error: "n" in "e._call_user_data_handler(operation, n, entity)" looks like a copy-paste error.
Python-3.6.5/Lib/xml/dom/minidom.py:1924: remediation: Should it say "e" instead?
\bpo-1922| clone.entities._seq.append(entity)
\bpo-1923| if hasattr(e, '_call_user_data_handler'):
\bpo-1924|-> e._call_user_data_handler(operation, n, entity)
\bpo-1925| else:
\bpo-1926| # Note the cloning of Document and DocumentType nodes is

It seems that the warning is indeed a bug, and the code in question was basically merged into python from pyxml 16 years ago.

[serhiy-storchaka]

Agree, this looks like a bug.

Do you mind to create a PR Charalampos?

[Shivank98]

Hey,
I am starting my journey with the contribution to CPython. and this is i think i can do these changes. if Charalampos is not there to work on it. i would like to try this.

[stratakis]

Hello Shivank. I had a PR ready locally which I was about to push, so you posted just at the right time :) Feel free to work on this issue.

[Shivank98]

Thanks, Charalampos :)
I would be thankful if you or Serhiy can help me a little bit.
so do I need to just do the following work?

1924--> n._call_user_data_handler(operation, n, entity)

[Shivank98]

*1924--> n._call_user_data_handler(operation, n, notation)

[serhiy-storchaka]

You need also to write a test.

[Shivank98]

Oh, I see, so I believe that's where my learning of CPython is going to start.
can anyone help me in completing this? what I understood till now is in minidom.py we need to change line 1924. else it, we need to create a test. I want to help in what should a test include and do we need to create a new function for it in test_minidom.py?

[Shivank98]

I want to help in
*need help in