Py_FinalizeEx unconditionally exists in Py_LIMITED_API

[AJNeufeld]

BPO	35259
Nosy	@ned-deily, @vadmium, @serhiy-storchaka, @AJNeufeld, @miss-islington
PRs	bpo-35259: Limit Py_FinalizeEx() to Py_LIMITED_API >= 0x03060000 #10620 [3.7] bpo-35259: Limit Py_FinalizeEx() to Py_LIMITED_API >= 0x03060000. (GH-10620) #11268 [3.6] bpo-35259: Limit Py_FinalizeEx() to Py_LIMITED_API >= 0x03060000. (GH-10620) #11269

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-12-21.06:21:02.281>
created_at = <Date 2018-11-15.18:24:51.512>
labels = ['interpreter-core', '3.7', '3.8', 'type-crash']
title = 'Py_FinalizeEx unconditionally exists in Py_LIMITED_API'
updated_at = <Date 2018-12-24.16:33:09.815>
user = 'https://github.com/AJNeufeld'

bugs.python.org fields:

activity = <Date 2018-12-24.16:33:09.815>
actor = 'ned.deily'
assignee = 'none'
closed = True
closed_date = <Date 2018-12-21.06:21:02.281>
closer = 'serhiy.storchaka'
components = ['Interpreter Core']
creation = <Date 2018-11-15.18:24:51.512>
creator = 'AJNeufeld'
dependencies = []
files = []
hgrepos = []
issue_num = 35259
keywords = ['patch']
message_count = 6.0
messages = ['329959', '330383', '332260', '332264', '332267', '332491']
nosy_count = 5.0
nosy_names = ['ned.deily', 'martin.panter', 'serhiy.storchaka', 'AJNeufeld', 'miss-islington']
pr_nums = ['10620', '11268', '11269']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'crash'
url = 'https://bugs.python.org/issue35259'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']

[AJNeufeld]

In application compiled with
  #define Py_LIMITED_API 0x03040000
this method was used
  Py_FinalizeEx()

Tested application with:
SET PATH=...;C:\Program Files\Python35
APPLICATION.EXE

Result:
Entry Point Not Found

(X) The procedure entry point Py_FinalizeEx could not be located
in the dynamic link library
C:\PATH\TO\APPLICATION.EXE

Expected Result:
Application runs

Rebuilding, after replacing Py_FinalizeEx(void) with Py_Finalize(void):
Application runs when pointing to 3.5 DLLs.

Suggested resolution:
Declaration should be restricted to ABI 3.6+:

#if !defined(Py_LIMITED_API) || Py_LIMITED_API+0 >= 0x03060000
PyAPI_FUNC(int) Py_FinalizeEx(void);
#endif

[vadmium]

I added the Py_FinalizeEx API in bpo-5319, but was relying on input from others about dealing with Py_LIMITED_API. After reading the documentation <https://docs.python.org/3.6/c-api/stable.html\>, I now see that the function would be considered part of the limited API because its documentation doesn’t say otherwise. So Arthur’s resolution is correct.

[serhiy-storchaka]

New changeset 3e8f962 by Serhiy Storchaka (Arthur Neufeld) in branch 'master':
bpo-35259: Limit Py_FinalizeEx() to Py_LIMITED_API >= 0x03060000. (GH-10620)
3e8f962

[miss-islington]

New changeset d1e7175 by Miss Islington (bot) in branch '3.7':
bpo-35259: Limit Py_FinalizeEx() to Py_LIMITED_API >= 0x03060000. (GH-10620)
d1e7175

[ned-deily]

New changeset 5241ecf by Ned Deily (Miss Islington (bot)) in branch '3.6':
bpo-35259: Limit Py_FinalizeEx() to Py_LIMITED_API >= 0x03060000. (GH-10620) (GH-11269)
5241ecf

[ned-deily]

New changeset ffc106c by Ned Deily (Miss Islington (bot)) in branch '3.7':
bpo-35259: Limit Py_FinalizeEx() to Py_LIMITED_API >= 0x03060000. (GH-10620)
ffc106c