Minor improvements in asdl_c.py and Python-ast.c

[serhiy-storchaka]

BPO	38083
Nosy	@Yhg1s, @ericsnowcurrently, @serhiy-storchaka
PRs	bpo-38083: Minor improvements in asdl_c.py and Python-ast.c. #15824

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-09-11.18:39:13.057>
created_at = <Date 2019-09-10.07:21:56.847>
labels = ['interpreter-core', '3.9']
title = 'Minor improvements in asdl_c.py and Python-ast.c'
updated_at = <Date 2019-09-11.18:39:13.053>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2019-09-11.18:39:13.053>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2019-09-11.18:39:13.057>
closer = 'serhiy.storchaka'
components = ['Interpreter Core']
creation = <Date 2019-09-10.07:21:56.847>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 38083
keywords = ['patch']
message_count = 4.0
messages = ['351582', '351606', '351607', '352010']
nosy_count = 3.0
nosy_names = ['twouters', 'eric.snow', 'serhiy.storchaka']
pr_nums = ['15824']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue38083'
versions = ['Python 3.9']

[serhiy-storchaka]

• Use the const qualifier for constant C strings. This will save memory for their copy in a modifiable memory.
• Intern field and attribute names. This will save time, as comparing interned strings is faster.
• Temporary incref a borrowed reference to a list item. Arbitrary Python code can be executed when convert an item to C values. The list containing the item can be modified and the reference can became dead if not incref it.

[Yhg1s]

New changeset 43c9731 by T. Wouters (Serhiy Storchaka) in branch 'master':
bpo-38083: Minor improvements in asdl_c.py and Python-ast.c. (GH-15824)
43c9731

[Yhg1s]

This doesn't feel like a change that's worth backporting to 3.8 at this point. Do you agree? Is there anything left to do for this bug?

[serhiy-storchaka]

Agree. The third item is actually a bug fix, but it is unlikely that such bug can be exposed in real code.