PyState_AddModule docs should say that it's not necessary to call it.

[encukou]

BPO	38159
Nosy	@encukou, @miss-islington
PRs	bpo-38159: Clarify documentation of PyState_AddModule #16101 [3.8] bpo-38159: Clarify documentation of PyState_AddModule (GH-16101) #17026 [3.7] bpo-38159: Clarify documentation of PyState_AddModule (GH-16101) #17027

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-11-06.14:23:10.158>
created_at = <Date 2019-09-13.13:25:39.465>
labels = []
title = "PyState_AddModule docs should say that it's not necessary to call it."
updated_at = <Date 2019-11-06.14:23:10.157>
user = 'https://github.com/encukou'

bugs.python.org fields:

activity = <Date 2019-11-06.14:23:10.157>
actor = 'petr.viktorin'
assignee = 'none'
closed = True
closed_date = <Date 2019-11-06.14:23:10.158>
closer = 'petr.viktorin'
components = []
creation = <Date 2019-09-13.13:25:39.465>
creator = 'petr.viktorin'
dependencies = []
files = []
hgrepos = []
issue_num = 38159
keywords = ['patch']
message_count = 4.0
messages = ['352320', '355823', '356033', '356034']
nosy_count = 2.0
nosy_names = ['petr.viktorin', 'miss-islington']
pr_nums = ['16101', '17026', '17027']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue38159'
versions = []

[encukou]

I've seen extension modules calling PyState_AddModule on init, despite Python doing this automatically.
It should be clarified that PyState_AddModule is for people who are writing alternative ways of creating/registering module objects.

[encukou]

New changeset 9bc94ec by Petr Viktorin in branch 'master':
bpo-38159: Clarify documentation of PyState_AddModule (GH-16101)
9bc94ec

[miss-islington]

New changeset 4342af0 by Miss Islington (bot) in branch '3.7':
[3.7] bpo-38159: Clarify documentation of PyState_AddModule (GH-16101) (GH-17027)
4342af0

[miss-islington]

New changeset 1270d2c by Miss Islington (bot) in branch '3.8':
[3.8] bpo-38159: Clarify documentation of PyState_AddModule (GH-16101) (GH-17026)
1270d2c