CodeCov/patch job stills runs on pull requests on 3.5 and 3.6 branches

[vstinner]

BPO	40156
Nosy	@vstinner, @larryhastings, @ned-deily
PRs	[3.6] bpo-40156: Copy Codecov configuration from master #19306 [3.5] bpo-40156: Copy Codecov configuration from master #19309

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2020-04-03.00:59:24.948>
created_at = <Date 2020-04-02.13:35:01.281>
labels = ['tests']
title = 'CodeCov/patch job stills runs on pull requests on 3.5 and 3.6 branches'
updated_at = <Date 2020-04-03.00:59:24.947>
user = 'https://github.com/vstinner'

bugs.python.org fields:

activity = <Date 2020-04-03.00:59:24.947>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2020-04-03.00:59:24.948>
closer = 'vstinner'
components = ['Tests']
creation = <Date 2020-04-02.13:35:01.281>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 40156
keywords = ['patch']
message_count = 7.0
messages = ['365594', '365606', '365607', '365612', '365645', '365651', '365659']
nosy_count = 3.0
nosy_names = ['vstinner', 'larry', 'ned.deily']
pr_nums = ['19306', '19309']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue40156'
versions = ['Python 3.5', 'Python 3.6']

[vstinner]

Larry Hastings (Python 3.5 release manager) failed to merge my security fix into Python 3.5. The Codecov job run on the PR, failed and it must pass to merge a PR if I understood correctly Larry:
#17344 (comment)

The same job also ran and failed on another security fix for Python 3.6:
#19304

I propose to copy .github/codecov.yml configuration from master to 3.5 and 3.6 branches to disable the Codecov "patch" job.

See also recent issue: bpo-39704 "Disable code coverage". Codecov should no longer post comments with the result of the code coverage analysis: it's disabled for the whole Python organization.

There are no longer "Codecov patch" jobs on the 3.7, 3.8 and master branches.

[vstinner]

Here is my concrete solution for CodeCov issues on 3.5 and 3.6 branches.

[larryhastings]

I need to do a little more reading on it, but I expect if you make an equivalent PR for 3.5 I'll merge it. Thanks for taking this on, Victor!

[vstinner]

I need to do a little more reading on it, but I expect if you make an equivalent PR for 3.5 I'll merge it. Thanks for taking this on, Victor!

Done with PR 19309.

[larryhastings]

New changeset ed07522 by Victor Stinner in branch '3.5':
bpo-40156: Copy Codecov configuration from master (bpo-19309)
ed07522

[ned-deily]

New changeset ebeabb5 by Victor Stinner in branch '3.6':
bpo-40156: Copy Codecov configuration from master (GH-19306)
ebeabb5

[vstinner]

Thanks Ned and Larry.