pythoncore.vcxproj fails to load due to duplicated "..\Include\pyhash.h"

[ammaraskar]

BPO	40401
Nosy	@pfmoore, @tjguk, @zware, @zooba, @ammaraskar
PRs	bpo-40401: Remove duplicate pyhash.h include from pythoncore.vcxproj #19725

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2020-04-27.02:09:02.784>
created_at = <Date 2020-04-26.23:53:07.153>
labels = ['build', '3.9', 'OS-windows']
title = 'pythoncore.vcxproj fails to load due to duplicated "..\\Include\\pyhash.h"'
updated_at = <Date 2020-04-27.02:09:02.783>
user = 'https://github.com/ammaraskar'

bugs.python.org fields:

activity = <Date 2020-04-27.02:09:02.783>
actor = 'zach.ware'
assignee = 'none'
closed = True
closed_date = <Date 2020-04-27.02:09:02.784>
closer = 'zach.ware'
components = ['Windows']
creation = <Date 2020-04-26.23:53:07.153>
creator = 'ammar2'
dependencies = []
files = []
hgrepos = []
issue_num = 40401
keywords = ['patch']
message_count = 3.0
messages = ['367334', '367352', '367353']
nosy_count = 5.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'steve.dower', 'ammar2']
pr_nums = ['19725']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue40401'
versions = ['Python 3.9']

[ammaraskar]

The pythoncore project currently fails to load in Visual Studio with:

cpython\PCbuild\pythoncore.vcxproj : error  : Cannot load project with duplicated project items: ..\Include\pyhash.h is included as 'ClInclude' and as 'ClInclude' item types. 

Looks like c5fc156#diff-fc48a1700be0140b57a172ea101297de accidentally introduced a duplicate for "..\Include\pyhash.h"

[zware]

New changeset a494caa by Ammar Askar in branch 'master':
bpo-40401: Remove duplicate pyhash.h include from pythoncore.vcxproj (GH-19725)
a494caa

[zware]

Thanks for the patch :)