Remove unused and unneeded function declaration from sqlite3 header files

[erlend-aasland]

BPO	40959
Nosy	@berkerpeksag, @erlend-aasland
PRs	bpo-40959: Remove unused and unneeded declarations from sqlite3 headers #20828

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2021-01-06.00:56:35.188>
created_at = <Date 2020-06-12.11:21:57.075>
labels = ['type-feature', 'library', '3.10']
title = 'Remove unused and unneeded function declaration from sqlite3 header files'
updated_at = <Date 2021-01-06.00:56:35.187>
user = 'https://github.com/erlend-aasland'

bugs.python.org fields:

activity = <Date 2021-01-06.00:56:35.187>
actor = 'berker.peksag'
assignee = 'none'
closed = True
closed_date = <Date 2021-01-06.00:56:35.188>
closer = 'berker.peksag'
components = ['Library (Lib)']
creation = <Date 2020-06-12.11:21:57.075>
creator = 'erlendaasland'
dependencies = []
files = []
hgrepos = []
issue_num = 40959
keywords = ['patch']
message_count = 3.0
messages = ['371353', '384461', '384462']
nosy_count = 2.0
nosy_names = ['berker.peksag', 'erlendaasland']
pr_nums = ['20828']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue40959'
versions = ['Python 3.10']

[erlend-aasland]

The following function declarations can safely be removed because they're either unused or unneeded.

In Modules/_sqlite/cache.h:
pysqlite_node_init() // unused; no function definition
pysqlite_node_dealloc() // unneeded; file scope
pysqlite_cache_init() // unneeded; file scope
pysqlite_cache_dealloc() // unneeded; file scope

In Modules/_sqlite/connection.h:
pysqlite_connection_alloc() // unused; no function definition
pysqlite_connection_dealloc() // unneeded; file scope
pysqlite_connection_cursor() // unneeded; file scope
pysqlite_connection_close() // unneeded; file scope
pysqlite_connection_rollback() // unneeded; file scope
pysqlite_connection_new() // unused; no function definition
pysqlite_connection_init() // unneeded; file scope

In Modules/_sqlite/cursor.h:
pysqlite_cursor_execute() // unneeded; file scope
pysqlite_cursor_executemany() // unneeded; file scope
pysqlite_cursor_getiter() // unused; no function definition
pysqlite_cursor_iternext() // unneeded; file scope
pysqlite_cursor_fetchone() // unneeded; file scope
pysqlite_cursor_fetchmany() // unneeded; file scope
pysqlite_cursor_fetchall() // unneeded; file scope
pysqlite_noop() // unneeded; file scope
pysqlite_cursor_close() // unneeded; file scope

In Modules/_sqlite/prepare_protocol.h:
pysqlite_prepare_protocol_init() // unneeded; file scope
pysqlite_prepare_protocol_dealloc() // unneeded; file scope

In Modules/_sqlite/statement.h:
pysqlite_statement_dealloc() // unneeded; file scope

[berkerpeksag]

New changeset 203b249 by Erlend Egeberg Aasland in branch 'master':
bpo-40959: Remove unused declarations from sqlite3 headers (GH-20828)
203b249

[berkerpeksag]

Thank you!