Fix SQLite warnings on macOS

[SamuelMarks]

BPO	42229
Nosy	@ronaldoussoren, @erlend-aasland, @SamuelMarks
PRs	bpo-42229: Fix SQLite warnings on macOS #23072

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2020-11-02.06:25:36.528>
created_at = <Date 2020-11-01.10:49:32.162>
labels = ['build', '3.9']
title = 'Fix SQLite warnings on macOS'
updated_at = <Date 2020-11-02.07:27:40.872>
user = 'https://github.com/SamuelMarks'

bugs.python.org fields:

activity = <Date 2020-11-02.07:27:40.872>
actor = 'samuelmarks'
assignee = 'none'
closed = True
closed_date = <Date 2020-11-02.06:25:36.528>
closer = 'samuelmarks'
components = ['Build']
creation = <Date 2020-11-01.10:49:32.162>
creator = 'samuelmarks'
dependencies = []
files = []
hgrepos = []
issue_num = 42229
keywords = []
message_count = 10.0
messages = ['380126', '380161', '380162', '380163', '380164', '380165', '380170', '380182', '380183', '380187']
nosy_count = 3.0
nosy_names = ['ronaldoussoren', 'erlendaasland', 'samuelmarks']
pr_nums = ['23072']
priority = 'normal'
resolution = None
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue42229'
versions = ['Python 3.9']

[SamuelMarks]

Planned to fix all the compiler warnings on macOS. Ended up just fixing this SQLite one:

Python-3.9.0/Modules/_sqlite/connection.c:1066:9: warning: 'sqlite3_trace' is deprecated: first deprecated in macOS 10.12
      [-Wdeprecated-declarations]
        sqlite3_trace(self->db, 0, (void*)0);
        ^~~~~~~~~~~~~
        sqlite3_trace_v2
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sqlite3.h:3022:36: note: 'sqlite3_trace' has
      been explicitly marked deprecated here
SQLITE_API SQLITE_DEPRECATED void *sqlite3_trace(
                                   ^
Python-3.9.0/Modules/_sqlite/connection.c:1069:9: warning: 'sqlite3_trace' is deprecated: first deprecated in macOS 10.12
      [-Wdeprecated-declarations]
        sqlite3_trace(self->db, _trace_callback, trace_callback);
        ^~~~~~~~~~~~~
        sqlite3_trace_v2
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sqlite3.h:3022:36: note: 'sqlite3_trace' has
      been explicitly marked deprecated here
SQLITE_API SQLITE_DEPRECATED void *sqlite3_trace(
                                   ^

Note that: sqlite3_enable_shared_cache should be removed from [Modules/_sqlite/module.c](https://github.com/python/cpython/blob/main/Modules/_sqlite/module.c) also, as warning and guide says: https://www.sqlite.org/c3ref/enable_shared_cache.html

Python-3.9.0/Modules/_sqlite/module.c:147:10: warning: 'sqlite3_enable_shared_cache' is deprecated: first deprecated in macOS
      10.7 - Not supported [-Wdeprecated-declarations]

But I think that would require a major version change, so let's keep that warning fix to one side.

Same with the tk issues, as per https://bugs.python.org/issue41016 ; although I suspect there's a way to quiet the warnings here…

[erlend-aasland]

FYI, commit 7f331c8 (GH-19581 / bpo-40318) migrates the sqlite3 to the new trace API.

There was also a discussion about sqlite3_enable_shared_cache() on bpo, but I think it was closed as "wont-fix", IIRC.

[erlend-aasland]

Look at bpo-24464 regarding the shared cache issue. Apparently I did not remember correctly regarding its status.

[SamuelMarks]

Yes, this commit extends his changes to include macOS support (for some reason that SQLite version check doesn’t work properly on macOS; so this checks the macOS version, knowing AOT when SQLite trace v1 APIs were deprecated.

Curious that sqlite3_enable_shared_cache is in the ‘wontfix’ category… why is this?

[erlend-aasland]

Oh, I see now that you're only mentioning 3.9 here. The issue was fixed in master only (that is 3.10 alpha). Perhaps #63780 should be backported to 3.9, or even 3.8, but that's not for me to decide.

Note: your patch is against 3.10, not 3.9.

[erlend-aasland]

Yes, this commit extends his changes to include macOS support (for some reason that SQLite version check doesn’t work properly on macOS

I can't reproduce this on master on macOS 10.15.7 with the SQLite 3.28.0 that's shipped with the os.

[SamuelMarks]

@erlendaasland Hmm… just double-checked, and this issue is present on Python 3.8.6 and 3.9.0 but not master [d3b4e06] as you referenced.

Should I close this issue—and PR—then? - Backport from master to these?

[erlend-aasland]

Should I close this issue—and PR—then? - Backport from master to these?

If this fix is wanted in 3.9 and 3.8, I think the correct way to proceed would be to close #67261 and backport #63780.

Try checking out 3.9 and cherrypicking 7f331c8 to verify that the trace-warning disappears. I'm pretty sure that SQLite3 version detection works on macOS.

[SamuelMarks]

👌

[SamuelMarks]

Opened two issues and two PRs for 3.8 and 3.8:

• https://bugs.python.org/issue42241
• https://bugs.python.org/issue42242