build.yml workflow not testing on pushes

[ammaraskar]

BPO	42773
Nosy	@vstinner, @ammaraskar, @Mariatta, @miss-islington, @FFY00
PRs	bpo-42773: fix tests not being run on pushes #24004 [3.8] bpo-42773: fix tests not being run on pushes (GH-24004) #24010 [3.9] bpo-42773: fix tests not being run on pushes (GH-24004) #24011 [3.8] bpo-42773: fix tests not being run on pushes (GH-24004) #24437 [3.9] bpo-42773: fix tests not being run on pushes (GH-24004) #24438

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2021-02-04.19:57:06.367>
created_at = <Date 2020-12-28.22:31:27.024>
labels = ['type-bug', '3.8', '3.9', '3.10', 'build', '3.7']
title = 'build.yml workflow not testing on pushes'
updated_at = <Date 2021-02-04.19:57:06.366>
user = 'https://github.com/ammaraskar'

bugs.python.org fields:

activity = <Date 2021-02-04.19:57:06.366>
actor = 'ammar2'
assignee = 'none'
closed = True
closed_date = <Date 2021-02-04.19:57:06.367>
closer = 'ammar2'
components = ['Build']
creation = <Date 2020-12-28.22:31:27.024>
creator = 'ammar2'
dependencies = []
files = []
hgrepos = []
issue_num = 42773
keywords = ['patch']
message_count = 9.0
messages = ['383935', '383937', '383941', '384030', '384067', '384074', '384077', '386467', '386468']
nosy_count = 5.0
nosy_names = ['vstinner', 'ammar2', 'Mariatta', 'miss-islington', 'FFY00']
pr_nums = ['24004', '24010', '24011', '24437', '24438']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue42773'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9', 'Python 3.10']

[ammaraskar]

It looks like on pushes to Github, we currently aren't running tests. (Though this isn't too big of a concern since they get run on pull requests).

Here's an example of a recent run https://github.com/python/cpython/runs/1609911031

fatal: ambiguous argument 'origin/..': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

[vstinner]

build.yml workflow not testing on pushes

What does it mean: "on pushes"?

[ammaraskar]

Any commit that gets to pushed to the master, 3.9, 3.8 and 3.7 branches.

e.g all the commits here https://github.com/python/cpython/commits/master, they end up failing the "Check for source changes" step and skipping even when there's non-documentation changes.

[FFY00]

This is due to a typo, I commented on the original PR and opened a PR fixing it. Cheers :)

[miss-islington]

New changeset 4ac923f by Filipe Laíns in branch 'master':
bpo-42773: fix tests not being run on pushes (GH-24004)
4ac923f

[FFY00]

Ammar, could you confirm the issue is now solved?

[ammaraskar]

Thank you Filipe and Mariatta, the fix looks good to me. I think it needs a backport to the 3.9 branch though.

[miss-islington]

New changeset d29dbb1 by Miss Islington (bot) in branch '3.8':
bpo-42773: fix tests not being run on pushes (GH-24004)
d29dbb1