[sqlite3] Improve sqlite3_value_text() error handling

[erlend-aasland]

BPO	43853
Nosy	@gvanrossum, @berkerpeksag, @serhiy-storchaka, @JelleZijlstra, @pablogsal, @miss-islington, @erlend-aasland
PRs	bpo-43853: Handle sqlite3_value_text() errors #25422 [3.10] bpo-43853: Handle sqlite3_value_text() errors (GH-25422) #26534 [3.9] bpo-43853: Handle sqlite3_value_text() errors (GH-25422). #27627 bpo-43853: Expand test suite for SQLite UDF's #27642 bpo-43853: Amend NEWS entry #27922 [3.9] bpo-43853: Amend NEWS entry for latest changes in sqlite3 (GH-27922) #27952 [3.10] bpo-43853: Amend NEWS entry for latest changes in sqlite3 (GH-27922) #27953 [3.10] bpo-43853: Expand test suite for SQLite UDF's (GH-27642) #31030 [3.9] bpo-43853: Expand test suite for SQLite UDF's (GH-27642) (GH-31030) #31586
Files	patch.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2022-03-02.06:41:01.374>
created_at = <Date 2021-04-15.10:00:09.823>
labels = ['extension-modules', 'type-bug', '3.9', '3.10', '3.11']
title = '[sqlite3] Improve sqlite3_value_text() error handling'
updated_at = <Date 2022-03-02.06:41:01.373>
user = 'https://github.com/erlend-aasland'

bugs.python.org fields:

activity = <Date 2022-03-02.06:41:01.373>
actor = 'erlendaasland'
assignee = 'none'
closed = True
closed_date = <Date 2022-03-02.06:41:01.374>
closer = 'erlendaasland'
components = ['Extension Modules']
creation = <Date 2021-04-15.10:00:09.823>
creator = 'erlendaasland'
dependencies = []
files = ['49961']
hgrepos = []
issue_num = 43853
keywords = ['patch']
message_count = 17.0
messages = ['391124', '394267', '395109', '395112', '399075', '399084', '399114', '399120', '400174', '400288', '400292', '400296', '400319', '401565', '411771', '413620', '414325']
nosy_count = 7.0
nosy_names = ['gvanrossum', 'berker.peksag', 'serhiy.storchaka', 'JelleZijlstra', 'pablogsal', 'miss-islington', 'erlendaasland']
pr_nums = ['25422', '26534', '27627', '27642', '27922', '27952', '27953', '31030', '31586']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue43853'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

[erlend-aasland]

Fix sqlite3_value_text() usage:

• Raise MemoryError if sqlite3_value_text() sets SQLITE_NOMEM
• Let PyUnicode_FromStringAndSize() errors propagate

Quoting the SQLite docs:
"As long as the input parameter is correct, these routines can only fail if an out-of-memory error occurs"

See also:

• bpo-43296
• https://sqlite.org/c3ref/value_blob.html

[erlend-aasland]

The affected branch is exercised by the following tests:

• test_aggr_check_param_blob
• test_aggr_check_param_float
• test_aggr_check_param_int
• test_aggr_check_param_none
• test_aggr_check_param_str
• test_aggr_check_params_int
• test_aggr_exception_in_finalize
• test_aggr_exception_in_step
• test_aggr_no_finalize
• test_param_string

I've expanded test_aggr_check_param_str and test_param_string to also check empty strings.

[pablogsal]

New changeset 006fd86 by Erlend Egeberg Aasland in branch 'main':
bpo-43853: Handle sqlite3_value_text() errors (GH-25422)
006fd86