regrtest fails to start on missing performance counter names

[jkloth]

BPO	46788
Nosy	@pfmoore, @vstinner, @tjguk, @jkloth, @zware, @eryksun, @zooba

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2022-03-22.17:22:32.326>
created_at = <Date 2022-02-18.16:36:09.375>
labels = ['3.10', 'tests', '3.9', 'OS-windows', '3.11']
title = 'regrtest fails to start on missing performance counter names'
updated_at = <Date 2022-03-22.19:51:55.435>
user = 'https://github.com/jkloth'

bugs.python.org fields:

activity = <Date 2022-03-22.19:51:55.435>
actor = 'eryksun'
assignee = 'none'
closed = True
closed_date = <Date 2022-03-22.17:22:32.326>
closer = 'steve.dower'
components = ['Tests', 'Windows']
creation = <Date 2022-02-18.16:36:09.375>
creator = 'jkloth'
dependencies = []
files = []
hgrepos = []
issue_num = 46788
keywords = []
message_count = 9.0
messages = ['413493', '415696', '415713', '415719', '415726', '415727', '415731', '415775', '415799']
nosy_count = 7.0
nosy_names = ['paul.moore', 'vstinner', 'tim.golden', 'jkloth', 'zach.ware', 'eryksun', 'steve.dower']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue46788'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

[jkloth]

When attempting to run the test harness, I receive the following:

Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "C:\Public\Devel\cpython\main\Lib\test\__main__.py", line 2, in <module>
    main()
    ^^^^^^
  File "C:\Public\Devel\cpython\main\Lib\test\libregrtest\main.py", line 736, in main
    Regrtest().main(tests=tests, **kwargs)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Public\Devel\cpython\main\Lib\contextlib.py", line 155, in __exit__
    self.gen.throw(typ, value, traceback)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Public\Devel\cpython\main\Lib\contextlib.py", line 155, in __exit__
    self.gen.throw(typ, value, traceback)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Public\Devel\cpython\main\Lib\test\support\os_helper.py", line 396, in temp_dir
    yield path
    ^^^^^^^^^^
  File "C:\Public\Devel\cpython\main\Lib\contextlib.py", line 155, in __exit__
    self.gen.throw(typ, value, traceback)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Public\Devel\cpython\main\Lib\test\support\os_helper.py", line 427, in change_cwd
    yield os.getcwd()
    ^^^^^^^^^^^^^^^^^
  File "C:\Public\Devel\cpython\main\Lib\test\support\os_helper.py", line 449, in temp_cwd
    yield cwd_dir
    ^^^^^^^^^^^^^
  File "C:\Public\Devel\cpython\main\Lib\test\libregrtest\main.py", line 658, in main
    self._main(tests, kwargs)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Public\Devel\cpython\main\Lib\test\libregrtest\main.py", line 704, in _main
    self.win_load_tracker = WindowsLoadTracker()
                            ^^^^^^^^^^^^^^^^^^^^
  File "C:\Public\Devel\cpython\main\Lib\test\libregrtest\win_utils.py", line 41, in __init__
    self.start()
    ^^^^^^^^^^^^
  File "C:\Public\Devel\cpython\main\Lib\test\libregrtest\win_utils.py", line 70, in start
    counter_name = self._get_counter_name()
                   ^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Public\Devel\cpython\main\Lib\test\libregrtest\win_utils.py", line 90, in _get_counter_name
    system = counters_dict['2']
             ~~~~~~~~~~~~~^^^^^
KeyError: '2'

This is due to my machine missing the localized names for the performance counters. Other performance monitoring tools operate just fine.

While I have been working around this issue for some time, it has become difficult to seperate the workarounds from actually changes in the test harness.

The PR (#26578) from https://bugs.python.org/issue44336 also solves this issue by accessing the counters directly instead of relying on their localized names.

[jkloth]

OK, I know it has been a busy month for Python, but this issue is really hampering my bug fixing efforts. It makes the complete regrtest useless for me. I am required to run each affected test directly so it is possible to miss side-effects of changes made.

The original PR is now 9 months old.

[zooba]

You're closer to this stuff than I am, so if you say it works for your scenarios and it doesn't break the existing ones, I'll merge it.

Do we need to backport to 3.8 at this point?