Skip to content

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Dec 5, 2022

Skip test_normalization() of test_unicodedata if it fails to download NormalizationTest.txt file from pythontest.net.

Skip test_normalization() of test_unicodedata if it fails to download
NormalizationTest.txt file from pythontest.net.
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@vstinner vstinner deleted the test_unicodedata branch December 5, 2022 15:37
@miss-islington
Copy link
Contributor

Sorry @vstinner, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 2488c1e1b66366a3a933ff248eff080fabd2351c 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2022
…onGH-100011)

Skip test_normalization() of test_unicodedata if it fails to download
NormalizationTest.txt file from pythontest.net.
(cherry picked from commit 2488c1e)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-bot
Copy link

GH-100012 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Dec 5, 2022
@vstinner vstinner added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Dec 5, 2022
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-100013 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Dec 5, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2022
…onGH-100011)

Skip test_normalization() of test_unicodedata if it fails to download
NormalizationTest.txt file from pythontest.net.
(cherry picked from commit 2488c1e)

Co-authored-by: Victor Stinner <[email protected]>
miss-islington added a commit that referenced this pull request Dec 5, 2022
Skip test_normalization() of test_unicodedata if it fails to download
NormalizationTest.txt file from pythontest.net.
(cherry picked from commit 2488c1e)

Co-authored-by: Victor Stinner <[email protected]>
miss-islington added a commit that referenced this pull request Dec 5, 2022
Skip test_normalization() of test_unicodedata if it fails to download
NormalizationTest.txt file from pythontest.net.
(cherry picked from commit 2488c1e)

Co-authored-by: Victor Stinner <[email protected]>
@benjaminp
Copy link
Contributor

Why not add retries to the fetch? I'm afraid this will silently disable the test forever if fetching the file becomes a permanent error.

@vstinner
Copy link
Member Author

vstinner commented Dec 6, 2022

Hi @benjaminp,

Why not add retries to the fetch?

My reason: I want to limit time spent on this issue :-) I only worked on it because I'm getting 1 to 5 emails per day related to test_unicodedata failures, but only on some workers which have other network issues. If someone else is volunteer to enhance the code, please go ahead ;-) A generic function "download a file from the Internet, retry on error, and skip the test after a timeout" sounds like an useful feature ;-)

@benjaminp
Copy link
Contributor

I very much understand not wanting to spend time. But, as I said, I'm afraid this could have scary side-effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants