-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
gh-100110: Specialize FOR_ITER for tuples #100109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for python-cpython-preview canceled.
|
|
I'm not sure that I entirely trust those stats, yet. |
markshannon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Have you attempted to benchmark this?
No. It's just one specialisation. I doubt anything in pyperformance will change. |
|
I'm running the stats on it. |
|
The stats show what I would expect. No specialization failures for tuples, and an increase of hit rates for |
Same as FOR_ITER_LIST, but it accounts for 57% of our current failures.
https://github.com/faster-cpython/ideas/blob/main/stats/pystats-python-a87c46e-2022-12-04.md#specialization-attempts-3