gh-101538: Add experimental wasi-threads build #101537

yamt · 2023-02-03T12:21:38Z

eg.

export WASI_SDK_PATH=/opt/wasi-sdk-19.5g0236e959edbc
./Tools/wasm/wasm_build.py wasi-threads build
~/git/toywasm/b.thread/toywasm --wasi --wasi-dir . --wasi-dir ~/git/garbage/py/th2 -- builddir/wasi-threads/python.wasm ~/git/garbage/py/th2/thread.py

I used an unreleased version of wasi-sdk
I used toywasm to test because wasmtime doesn't have
necessary functionality yet.

Issue: Add threading support based on wasi-threads #101538

bedevere-bot · 2023-02-03T12:21:43Z

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

ghost · 2023-02-03T12:22:06Z

All commit authors signed the Contributor License Agreement.

bedevere-bot · 2023-02-03T12:23:13Z

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

arhadthedev · 2023-02-03T12:30:06Z

Would you mind adding the news entry as the bot suggests? Add experimental wasi-threads support. Patch by Takashi Yamamoto. is sufficient.

bedevere-bot · 2023-02-03T12:31:45Z

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

eg. ``` autoconf export WASI_SDK_PATH=/opt/wasi-sdk-19.5g0236e959edbc ./Tools/wasm/wasm_build.py wasi-threads build ~/git/toywasm/b.thread/toywasm --wasi --wasi-dir . --wasi-dir ~/git/garbage/py/th2 -- builddir/wasi-threads/python.wasm ~/git/garbage/py/th2/thread.py ``` * I used an unreleased version of wasi-sdk * I used toywasm to test because wasmtime doesn't have necessary functionality yet.

yamt · 2023-02-03T12:37:36Z

Would you mind adding the news entry as the bot suggests? Add experimental wasi-threads support. Patch by Takashi Yamamoto. is sufficient.

thank you. done.

``` docker run --rm -v $(pwd):/src quay.io/tiran/cpython_autoconf:269 ```

arhadthedev · 2023-02-03T13:48:34Z

No need to rebase and force-push; everything will be squashed into a single commit while merging anyway.

yamt · 2023-02-03T13:57:01Z

No need to rebase and force-push; everything will be squashed into a single commit while merging anyway.

ok. i was not aware of the policy. thank you.

erlend-aasland · 2023-02-04T08:47:00Z

ok. i was not aware of the policy. thank you.

It is documented in the devguide: https://devguide.python.org/getting-started/pull-request-lifecycle/#submitting

configure.ac

yamt · 2023-02-06T05:38:29Z

ok. i was not aware of the policy. thank you.

It is documented in the devguide: https://devguide.python.org/getting-started/pull-request-lifecycle/#submitting

ok. i was aware of the doc. but apparently i haven't read it carefully enough. thank you for pointing out.

brettcannon · 2023-02-10T23:20:25Z

As I rejected the feature request I am also unfortunately rejecting this PR.

brettcannon · 2023-04-05T23:40:56Z

FYI in case this PR gets re-opened (instead of a new one) when WASI threads goes stable, I was able to build with WASI SDK 20 and this PR.

brettcannon · 2023-06-12T22:43:42Z

@yamt I got tacit approval to turn this on as long as it is clearly marked as experimental. Did you want to refresh this PR as necessary?

erlend-aasland · 2023-06-14T08:38:46Z

@yamt, I marked our Autoconf conversation as resolved and also took the liberty to apply a small Autoconf style change. Hope you don't mind.

yamt · 2023-06-21T23:53:29Z

@yamt, I marked our Autoconf conversation as resolved and also took the liberty to apply a small Autoconf style change. Hope you don't mind.

thank you.

erlend-aasland · 2023-06-22T07:41:57Z

AFAICS, we can land this now, @brettcannon. I'll wait a couple of days to give you a chance to look over it before merging :)

brettcannon · 2023-06-22T18:25:21Z

It's experimental (and even undocumented ATM 😅), so I'm good with it.

brettcannon · 2023-06-22T18:26:59Z

@yamt Thanks! I will update https://github.com/brettcannon/cpython-wasi-build probably in the next week or so to start producing a threaded build for WASI on top of the "normal" build w/o threads.

Co-authored-by: Brett Cannon <[email protected]> Co-authored-by: Erlend E. Aasland <[email protected]>

brettcannon · 2023-07-12T00:16:40Z

@Yhg1s is it okay to backport this to 3.12?

Yhg1s · 2023-07-17T19:26:11Z

Yes, this is fine for 3.12 (if it gets into RC1, scheduled for 2 weeks from now).

miss-islington · 2023-07-17T19:45:59Z

Thanks @yamt for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

bedevere-bot · 2023-07-17T19:46:11Z

GH-106834 is a backport of this pull request to the 3.12 branch.

(cherry picked from commit d8f87cd) Co-authored-by: YAMAMOTO Takashi <[email protected]> Co-authored-by: Brett Cannon <[email protected]> Co-authored-by: Erlend E. Aasland <[email protected]>

…06834) (cherry picked from commit d8f87cd) Co-authored-by: YAMAMOTO Takashi <[email protected]> Co-authored-by: Brett Cannon <[email protected]> Co-authored-by: Erlend E. Aasland <[email protected]>

yamt requested review from corona10 and erlend-aasland as code owners February 3, 2023 12:21

bedevere-bot added the awaiting review label Feb 3, 2023

yamt force-pushed the wasi-threads branch from fb625af to 1dc81ae Compare February 3, 2023 12:23

arhadthedev added interpreter-core (Objects, Python, Grammar, and Parser dirs) OS-wasi labels Feb 3, 2023

yamt force-pushed the wasi-threads branch from 1dc81ae to 564fa2b Compare February 3, 2023 12:31

yamt changed the title ~~Add experimental wasi-threads build~~ gh-101538: Add experimental wasi-threads build Feb 3, 2023

bedevere-bot mentioned this pull request Feb 3, 2023

Add threading support based on wasi-threads #101538

Closed

yamt force-pushed the wasi-threads branch from 564fa2b to 0ef8b66 Compare February 3, 2023 12:37

Regen configure

c4543e1

``` docker run --rm -v $(pwd):/src quay.io/tiran/cpython_autoconf:269 ```

yamt mentioned this pull request Feb 3, 2023

Is wasi_thread_exit needed? WebAssembly/wasi-threads#7

Open

yamt added 2 commits February 4, 2023 16:35

revert unnecessary config override

0980549

add a comment

a1959a3

erlend-aasland reviewed Feb 4, 2023

View reviewed changes

configure.ac Outdated Show resolved Hide resolved

yamt added 2 commits February 11, 2023 03:01

configure.ac: add a comment

ce7d5c2

Regen configure

bb26aa2

brettcannon closed this Feb 10, 2023

brettcannon reopened this Jun 12, 2023

Merge branch 'main' into wasi-threads

1393295

erlend-aasland added 2 commits June 14, 2023 10:36

Style: use AS_VAR_APPEND throughout the PR

dd60e0a

Pull in main

bd6231f

erlend-aasland approved these changes Jun 14, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Jun 14, 2023

brettcannon merged commit d8f87cd into python:main Jun 22, 2023

bedevere-bot removed the awaiting merge label Jun 22, 2023

bentasker pushed a commit to bentasker/cpython that referenced this pull request Jun 23, 2023

pythongh-101538: Add experimental wasi-threads build (python#101537)

2df334b

Co-authored-by: Brett Cannon <[email protected]> Co-authored-by: Erlend E. Aasland <[email protected]>

erlend-aasland added the needs backport to 3.12 only security fixes label Jul 17, 2023

bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 17, 2023

Uh oh!

gh-101538: Add experimental wasi-threads build #101537

gh-101538: Add experimental wasi-threads build #101537

Uh oh!

Conversation

yamt commented Feb 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-bot commented Feb 3, 2023

Uh oh!

ghost commented Feb 3, 2023 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-bot commented Feb 3, 2023

Uh oh!

arhadthedev commented Feb 3, 2023

Uh oh!

bedevere-bot commented Feb 3, 2023

Uh oh!

yamt commented Feb 3, 2023

Uh oh!

arhadthedev commented Feb 3, 2023

Uh oh!

yamt commented Feb 3, 2023

Uh oh!

erlend-aasland commented Feb 4, 2023

Uh oh!

Uh oh!

yamt commented Feb 6, 2023

Uh oh!

brettcannon commented Feb 10, 2023

Uh oh!

brettcannon commented Apr 5, 2023

Uh oh!

brettcannon commented Jun 12, 2023

Uh oh!

erlend-aasland commented Jun 14, 2023

Uh oh!

yamt commented Jun 21, 2023

Uh oh!

erlend-aasland commented Jun 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brettcannon commented Jun 22, 2023

Uh oh!

brettcannon commented Jun 22, 2023

Uh oh!

brettcannon commented Jul 12, 2023

Uh oh!

Yhg1s commented Jul 17, 2023

Uh oh!

miss-islington commented Jul 17, 2023

Uh oh!

bedevere-bot commented Jul 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

yamt commented Feb 3, 2023 •

edited

Loading

ghost commented Feb 3, 2023 •

edited by ghost

Loading

erlend-aasland commented Jun 22, 2023 •

edited

Loading