bpo-35139: The pyexpat module's macros in Modules/Setup now matches setup.py
#10289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `setup.py` This could cause compile errors on macOS or other platforms.
Contributor
|
Thanks @maxbelanger for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7. |
|
GH-10291 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 2, 2018
…w match `setup.py` (pythonGH-10289) This could cause compile errors on macOS or other platforms. (cherry picked from commit 318ab63) Co-authored-by: Max Bélanger <[email protected]>
|
GH-10292 is a backport of this pull request to the 3.6 branch. |
Contributor
|
Sorry, @maxbelanger and @benjaminp, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 2, 2018
…w match `setup.py` (pythonGH-10289) This could cause compile errors on macOS or other platforms. (cherry picked from commit 318ab63) Co-authored-by: Max Bélanger <[email protected]>
benjaminp
pushed a commit
that referenced
this pull request
Nov 2, 2018
…up` now match `setup.py` (GH-10289) This could cause compile errors on macOS or other platforms.. (cherry picked from commit 318ab63) Co-authored-by: Max Bélanger <[email protected]>
|
GH-10293 is a backport of this pull request to the 2.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Nov 2, 2018
…w match `setup.py` (GH-10289) This could cause compile errors on macOS or other platforms. (cherry picked from commit 318ab63) Co-authored-by: Max Bélanger <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Nov 2, 2018
…w match `setup.py` (GH-10289) This could cause compile errors on macOS or other platforms. (cherry picked from commit 318ab63) Co-authored-by: Max Bélanger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could cause compile errors on macOS or other platforms.
https://bugs.python.org/issue35139