bpo-35202: Remove unused imports in idle lib package #10438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srinivasreddy
changed the title
srinivasreddy
requested review from
gvanrossum and
ilevkivskyi
as code owners
srinivasreddy
changed the title
Member
|
Please revert this PR to the original title and to only change idlelib. These changes can and should be backported to 3.7 and 3.6. If you can, add a generic blurb using the current 'lib' title. Then I will merge. Put other changes in a separate PR for the same issue, as those likely will not be backported. If there is a blurb with this PR, another PR will not need a blurb as there should be only 1 blurb per issue. |
srinivasreddy
changed the title
Contributor
|
Thanks @srinivasreddy for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
GH-10447 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 10, 2018
(cherry picked from commit 43a74ab) Co-authored-by: Srinivas Thatiparthy (శ్రీనివాస్ తాటిపర్తి) <[email protected]>
|
GH-10448 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 10, 2018
(cherry picked from commit 43a74ab) Co-authored-by: Srinivas Thatiparthy (శ్రీనివాస్ తాటిపర్తి) <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Nov 10, 2018
(cherry picked from commit 43a74ab) Co-authored-by: Srinivas Thatiparthy (శ్రీనివాస్ తాటిపర్తి) <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Nov 10, 2018
(cherry picked from commit 43a74ab) Co-authored-by: Srinivas Thatiparthy (శ్రీనివాస్ తాటిపర్తి) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue35202