gh-104340: Suppress warning about unawaited exception for closed pipe stdin #104586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
gvanrossum
added
3.12
Member
Author
|
Waiting for @kumaraditya303, but I'd like to get this in 3.12, since it's so minor. |
Contributor
|
LGTM |
Contributor
|
Thanks @gvanrossum for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-104594 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 17, 2023
…d pipe stdin (pythonGH-104586) (cherry picked from commit 7fc8e2d) Co-authored-by: Guido van Rossum <[email protected]>
gvanrossum
added a commit
that referenced
this pull request
May 18, 2023
…ed pipe stdin (GH-104586) (#104594) (cherry picked from commit 7fc8e2d) Co-authored-by: Guido van Rossum <[email protected]>
JelleZijlstra
pushed a commit
to JelleZijlstra/cpython
that referenced
this pull request
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to my analysis in the issue, the warning is more annoying/distracting than useful, and since the docs for
StreamWriter.close()say that callingwait_closed()is optional, we shouldn't penalize users for not waiting if there was an error (e.g.BrokenPipeErrorindrain()).