Skip to content

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 7, 2023

(cherry picked from commit 264a011)

Co-authored-by: Kirill Podoprigora [email protected]

(cherry picked from commit 264a011)

Co-authored-by: Kirill Podoprigora <[email protected]>
@AlexWaygood
Copy link
Member

AlexWaygood commented Jun 7, 2023

@pablogsal, remember that miss-islington never merges any PRs anymore, so approving a miss-islington PR doesn't do anything. You have to enable GitHub automerge on a backport PR if you want it to be merged once the CI checks have completed :)

@pablogsal pablogsal merged commit 3d4a786 into python:3.12 Jun 7, 2023
@miss-islington miss-islington deleted the backport-264a011-3.12 branch June 7, 2023 22:46
@pablogsal
Copy link
Member

@pablogsal, remember that miss-islington never merges any PRs anymore, so approving a miss-islington PR doesn't do anything. You have to enable GitHub automerge on a backport PR if you want it to be merged once the CI checks have completed :)

Thanks for the heads up! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants