Skip to content

Conversation

@ambv
Copy link
Contributor

@ambv ambv commented Jul 22, 2023

in the case of an empty FRAMEWORKALTINSTALLLAST, this patch prevents leaving an astray linebreak and two tabs in the resulting Makefile.

Before change:

.PHONY: commoninstall
commoninstall:  check-clean-src  \
		altbininstall libinstall inclinstall libainstall \
		sharedinstall altmaninstall \

After change (with empty FRAMEWORKALTINSTALLLAST):

.PHONY: commoninstall
commoninstall:  check-clean-src  \
		altbininstall libinstall inclinstall libainstall \
		sharedinstall altmaninstall

(cherry picked from commit 9c38206)

…pty FRAMEWORKALTINSTALLLAST (pythonGH-107035)

in the case of an empty FRAMEWORKALTINSTALLLAST, this patch prevents leaving
an astray linebreak and two tabs in the resulting Makefile.

Before change:
```
.PHONY: commoninstall
commoninstall:  check-clean-src  \
		altbininstall libinstall inclinstall libainstall \
		sharedinstall altmaninstall \

```

After change (with empty FRAMEWORKALTINSTALLLAST):
```
.PHONY: commoninstall
commoninstall:  check-clean-src  \
		altbininstall libinstall inclinstall libainstall \
		sharedinstall altmaninstall
```
(cherry picked from commit 9c38206)

Co-authored-by: Moritz Neeb <[email protected]>
@ambv ambv merged commit 5a74566 into python:3.11 Jul 23, 2023
@ambv ambv deleted the backport-9c38206-3.11 branch July 23, 2023 09:29
@ambv ambv restored the backport-9c38206-3.11 branch July 23, 2023 09:37
@ambv ambv deleted the backport-9c38206-3.11 branch July 23, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants