Skip to content

bpo-33012: Fix signatures of METH_NOARGS funstions. #10736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 1 commit into from
Nov 27, 2018
Merged

bpo-33012: Fix signatures of METH_NOARGS funstions. #10736

serhiy-storchaka merged 1 commit into from
Nov 27, 2018

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Nov 27, 2018 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka merged commit 8152402 into python:master Nov 27, 2018
@miss-islington
Copy link
Contributor

miss-islington commented Nov 27, 2018

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the noarg-sig branch November 27, 2018 11:05
@miss-islington
Copy link
Contributor

miss-islington commented Nov 27, 2018

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 81524022d0c0df7a41f9b2b2df41e2ebe140e610 3.7

@miss-islington
Copy link
Contributor

miss-islington commented Nov 27, 2018

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 81524022d0c0df7a41f9b2b2df41e2ebe140e610 3.6

@miss-islington
Copy link
Contributor

miss-islington commented Nov 27, 2018

Sorry, @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 81524022d0c0df7a41f9b2b2df41e2ebe140e610 2.7

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Nov 27, 2018
@serhiy-storchaka
[3.7] bpo-33012: Fix signatures of METH_NOARGS funstions. (pythonGH-1…
0196043 
…0736).

(cherry picked from commit 8152402)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Nov 27, 2018

GH-10748 is a backport of this pull request to the 3.7 branch.

serhiy-storchaka added a commit that referenced this pull request Nov 27, 2018
@serhiy-storchaka
bpo-33012: Fix signatures of METH_NOARGS functions. (GH-10736) (GH-10748
ad8ac54 
)

(cherry picked from commit 8152402)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 27, 2018
@serhiy-storchaka @miss-islington
bpo-33012: Fix signatures of METH_NOARGS functions. (pythonGH-10736) (p…
6e131b8 
…ythonGH-10748)

(cherry picked from commit 8152402)
(cherry picked from commit ad8ac54)

Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington added a commit that referenced this pull request Nov 27, 2018
@miss-islington @serhiy-storchaka
bpo-33012: Fix signatures of METH_NOARGS functions. (GH-10736) (GH-10748
d5c8bd8 
)

(cherry picked from commit 8152402)
(cherry picked from commit ad8ac54)

Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka @miss-islington @bedevere-bot @the-knights-who-say-ni