Skip to content

gh-107630: Initialize Each Interpreter's refchain Properly #107733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ericsnowcurrently merged 1 commit into from
Aug 7, 2023
Merged

gh-107630: Initialize Each Interpreter's refchain Properly #107733

ericsnowcurrently merged 1 commit into from
Aug 7, 2023

Conversation

@ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Aug 7, 2023 •
edited
Loading

This finishes fixing the crashes in Py_TRACE_REFS builds. We missed this part in gh-107567.

@bedevere-bot bedevere-bot mentioned this pull request Aug 6, 2023
Closed
@ericsnowcurrently
Copy link
Member Author

ericsnowcurrently commented Aug 7, 2023 •
edited
Loading

I'll be backporting this to 3.12 manually. (See gh-107737.)

@ericsnowcurrently ericsnowcurrently merged commit 430632d into python:main Aug 7, 2023
@ericsnowcurrently ericsnowcurrently deleted the fix-tracerefs branch August 7, 2023 19:15
This was referenced Aug 7, 2023
Closed
Merged
Merged
ericsnowcurrently added a commit that referenced this pull request Aug 7, 2023
@ericsnowcurrently
gh-107630: Fix Remaining Subinterpreters Crashes on Py_TRACE_REFS Bui…
707018c 
…lds (gh-107750)

This is a follow-up to gh-107567 and gh-107733.

We skip test_basic_multiple_interpreters_deleted_no_reset on tracerefs builds.  The test breaks interpreter isolation a little, which doesn't work well with Py_TRACE_REFS builds, so I feel fine about skipping the test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ericsnowcurrently @bedevere-bot