Skip to content

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Dec 5, 2018

@vstinner vstinner removed the skip news label Dec 5, 2018
@vstinner
Copy link
Member Author

vstinner commented Dec 5, 2018

@ned-deily, @pablogsal: I propose to revert the change since it caused a regression:
https://bugs.python.org/issue34172#msg330955

@pablogsal is working on a fix https://bugs.python.org/issue35378 but I'm not fully happy with it. Even if it's a good change, I dislike pushing late fix just before a release. I would prefer to have more time to experiment the overall change and make sure that it's the best option.

https://bugs.python.org/issue34172 is likely a very old bug, as old as multiprocessing. So yeah, it should be fixed, but not by changing the behavior in a stable branch.

Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if it's a good change, I dislike pushing late fix just before a release. I would prefer to have more time to experiment with the overall change and make sure that it's the best option.

I fully agree with this. Is better not to change the behaviour in maintenance branches especially when the change introduces a regression. Letś iterate over this in master.

@vstinner
Copy link
Member Author

vstinner commented Dec 6, 2018

@pablogsal: For the NEWS entry, I had to add a new "REVERT: xxx" entry, since the previous one is already part of 3.7.1rc2. Is it ok?

@pablogsal
Copy link
Member

@vstinner Looks good to me.

@vstinner vstinner merged commit 3c6b0d9 into python:3.7 Dec 6, 2018
@bedevere-bot
Copy link

@vstinner: Please replace # with GH- in the commit message next time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants