Skip to content

Conversation

@iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Sep 26, 2023

There is an optimization in the compiler where it removes redundant NOPs, and this assertion checks that it doesn't miss any.

Through fuzzing, it was found that in the case where there is a basic block with just a single instruction which is a redundant NOP, the NOP is not being removed (see #109889).

This close to the 3.12.0 release, I am proposing to comment out the assertion. There is no correctness issue here (just an extra NOP in some unlikely code).

I will work on a proper fix for the optimization for 3.13 and 3.12.1.

@AlexWaygood
Copy link
Member

AlexWaygood commented Sep 26, 2023

Looks like this leads to a bunch of compiler warnings being emitted on line 370:

‘no_redundant_nops’ defined but not used [-Wunused-function]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants