bpo-35444: Unify and optimize the helper for getting a builtin object. #11047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This speeds up pickling of some iterators. This fixes also error handling in pickling methods when fail to look up builtin "getattr".
methane
approved these changes
Dec 11, 2018
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Dec 11, 2018
…pythonGH-11047) (cherry picked from commit bb86bf4)
serhiy-storchaka
added a commit
that referenced
this pull request
Dec 11, 2018
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 11, 2018
…pythonGH-11047) (pythonGH-11107) (cherry picked from commit bb86bf4) (cherry picked from commit 3cae16d) Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up pickling of some iterators.
This fixes also error handling in pickling methods when fail to
look up builtin "getattr".
https://bugs.python.org/issue35444