Skip to content

gh-110647: Fix signal test_stress_modifying_handlers() #110650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
Oct 10, 2023
Merged

gh-110647: Fix signal test_stress_modifying_handlers() #110650

vstinner merged 1 commit into from
Oct 10, 2023

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Oct 10, 2023 •
edited by bedevere-app bot
Loading

  • cycle_handlers() now waits until at least one signal is received.
  • num_received_signals can be equal to num_sent_signals.

@vstinner
pythongh-110647: Fix signal test_stress_modifying_handlers()
ee14a38 
* cycle_handlers() now waits until at least one signal is received.
* num_received_signals can be equal to num_sent_signals.
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting review labels Oct 10, 2023
@bedevere-app bedevere-app bot mentioned this pull request Oct 10, 2023
Closed
@vstinner vstinner added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 10, 2023
@vstinner
Copy link
Member Author

vstinner commented Oct 10, 2023

Address sanitizer failed: I created issue gh-110656.

FAIL: test_post_fork_child_no_deadlock (test.test_logging.HandlerTest.test_post_fork_child_no_deadlock)
Ensure child logging locks are not held; bpo-6721 & bpo-36533.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/test/test_logging.py", line 789, in test_post_fork_child_no_deadlock
    support.wait_process(pid, exitcode=0)
  File "/home/runner/work/cpython/cpython/Lib/test/support/__init__.py", line 2206, in wait_process
    raise AssertionError(f"process {pid} is still running "
AssertionError: process 12448 is still running after 300.4 seconds

@vstinner vstinner enabled auto-merge (squash) October 10, 2023 23:46
@vstinner vstinner merged commit e07c37c into python:main Oct 10, 2023
@vstinner vstinner deleted the test_signal branch October 10, 2023 23:59
@miss-islington
Copy link
Contributor

miss-islington commented Oct 10, 2023

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 10, 2023
@vstinner @miss-islington
pythongh-110647: Fix signal test_stress_modifying_handlers() (pythonG…
71cc381 
…H-110650)

* cycle_handlers() now waits until at least one signal is received.
* num_received_signals can be equal to num_sent_signals.
(cherry picked from commit e07c37c)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 10, 2023

GH-110658 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 10, 2023
@bedevere-app
Copy link

bedevere-app bot commented Oct 11, 2023

GH-110659 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Oct 11, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 11, 2023
@vstinner @miss-islington
pythongh-110647: Fix signal test_stress_modifying_handlers() (pythonG…
0cec86e 
…H-110650)

* cycle_handlers() now waits until at least one signal is received.
* num_received_signals can be equal to num_sent_signals.
(cherry picked from commit e07c37c)

Co-authored-by: Victor Stinner <[email protected]>
@vstinner
Copy link
Member Author

vstinner commented Oct 11, 2023

Merged. Thanks for the review @barneygale.

vstinner added a commit that referenced this pull request Oct 11, 2023
@miss-islington @vstinner
[3.11] gh-110647: Fix signal test_stress_modifying_handlers() (GH-110650
46347d3 
) (#110659)

gh-110647: Fix signal test_stress_modifying_handlers() (GH-110650)

* cycle_handlers() now waits until at least one signal is received.
* num_received_signals can be equal to num_sent_signals.
(cherry picked from commit e07c37c)

Co-authored-by: Victor Stinner <[email protected]>
vstinner added a commit that referenced this pull request Oct 11, 2023
@miss-islington @vstinner
[3.12] gh-110647: Fix signal test_stress_modifying_handlers() (GH-110650
dcd47e5 
) (#110658)

gh-110647: Fix signal test_stress_modifying_handlers() (GH-110650)

* cycle_handlers() now waits until at least one signal is received.
* num_received_signals can be equal to num_sent_signals.
(cherry picked from commit e07c37c)

Co-authored-by: Victor Stinner <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@vstinner @Glyphack
pythongh-110647: Fix signal test_stress_modifying_handlers() (python#…
4896d1c 
…110650)

* cycle_handlers() now waits until at least one signal is received.
* num_received_signals can be equal to num_sent_signals.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barneygale barneygale barneygale approved these changes

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @miss-islington @barneygale