Skip to content

gh-110656: Fix logging test_post_fork_child_no_deadlock() if ASAN #110657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
Oct 11, 2023
Merged

gh-110656: Fix logging test_post_fork_child_no_deadlock() if ASAN #110657

vstinner merged 1 commit into from
Oct 11, 2023

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Oct 10, 2023 •
edited by bedevere-app bot
Loading

Skip test_post_fork_child_no_deadlock() if Python is built with ASAN.

Add support.HAVE_ASAN_FORK_BUG.

@vstinner vstinner requested a review from vsajip as a code owner October 10, 2023 23:47
@bedevere-app bedevere-app bot mentioned this pull request Oct 10, 2023
Closed
@vstinner vstinner force-pushed the test_logging_skip_fork branch from f6213ad to 0998c51 Compare October 10, 2023 23:47
@vstinner vstinner added tests Tests in the Lib/test dir skip news labels Oct 10, 2023
@vstinner
Copy link
Member Author

vstinner commented Oct 11, 2023

Windows x64 failed with:

FAIL: test_async_timeout (test.test_multiprocessing_spawn.test_manager.WithManagerTestPool.test_async_timeout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\Lib\test\_test_multiprocessing.py", line 2579, in test_async_timeout
    self.assertRaises(multiprocessing.TimeoutError, get, timeout=TIMEOUT2)

I created issue gh-110662 to track this test.

@vstinner
pythongh-110656: Fix logging test_post_fork_child_no_deadlock() if ASAN
054ec0a 
Skip test_post_fork_child_no_deadlock() if Python is built with ASAN.

Add support.HAVE_ASAN_FORK_BUG.
@vstinner vstinner force-pushed the test_logging_skip_fork branch from 0998c51 to 054ec0a Compare October 11, 2023 00:27
@vstinner vstinner merged commit f901f56 into python:main Oct 11, 2023
@vstinner vstinner deleted the test_logging_skip_fork branch October 11, 2023 00:57
@vstinner vstinner added the needs backport to 3.12 only security fixes label Oct 11, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Oct 11, 2023

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 11, 2023
@vstinner @miss-islington
pythongh-110656: Fix logging test_post_fork_child_no_deadlock() if AS…
bd3b74a 
…AN (pythonGH-110657)

Skip test_post_fork_child_no_deadlock() if Python is built with ASAN.

Add support.HAVE_ASAN_FORK_BUG.
(cherry picked from commit f901f56)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 11, 2023

GH-110664 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 11, 2023
@vstinner vstinner added the needs backport to 3.11 only security fixes label Oct 11, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Oct 11, 2023

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-app
Copy link

bedevere-app bot commented Oct 11, 2023

GH-110665 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Oct 11, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 11, 2023
@vstinner @miss-islington
pythongh-110656: Fix logging test_post_fork_child_no_deadlock() if AS…
e82636b 
…AN (pythonGH-110657)

Skip test_post_fork_child_no_deadlock() if Python is built with ASAN.

Add support.HAVE_ASAN_FORK_BUG.
(cherry picked from commit f901f56)

Co-authored-by: Victor Stinner <[email protected]>
vstinner added a commit that referenced this pull request Oct 11, 2023
@miss-islington @vstinner
[3.11] gh-110656: Fix logging test_post_fork_child_no_deadlock() if A…
7984dc2 
…SAN (GH-110657) (#110665)

gh-110656: Fix logging test_post_fork_child_no_deadlock() if ASAN (GH-110657)

Skip test_post_fork_child_no_deadlock() if Python is built with ASAN.

Add support.HAVE_ASAN_FORK_BUG.
(cherry picked from commit f901f56)

Co-authored-by: Victor Stinner <[email protected]>
vstinner added a commit that referenced this pull request Oct 11, 2023
@miss-islington @vstinner
[3.12] gh-110656: Fix logging test_post_fork_child_no_deadlock() if A…
55448a5 
…SAN (GH-110657) (#110664)

gh-110656: Fix logging test_post_fork_child_no_deadlock() if ASAN (GH-110657)

Skip test_post_fork_child_no_deadlock() if Python is built with ASAN.

Add support.HAVE_ASAN_FORK_BUG.
(cherry picked from commit f901f56)

Co-authored-by: Victor Stinner <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@vstinner @Glyphack
pythongh-110656: Fix logging test_post_fork_child_no_deadlock() if AS…
8283a34 
…AN (python#110657)

Skip test_post_fork_child_no_deadlock() if Python is built with ASAN.

Add support.HAVE_ASAN_FORK_BUG.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @miss-islington