GH-109369 Add vectorcall to PyLong_Type
#111642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
approved these changes
Nov 2, 2023
Objects/longobject.c
Outdated
| return long_new_impl(_PyType_CAST(type), args[0], args[1]); | ||
| default: | ||
| return PyErr_Format(PyExc_TypeError, | ||
| "int expected at most 2 argument%s, got %zd", nargs); |
Member
There was a problem hiding this comment.
Is the indentation right here?
Member
Author
There was a problem hiding this comment.
Probably not. I'll fix it
eendebakpt
reviewed
Nov 2, 2023
FullteaR
pushed a commit
to FullteaR/cpython
that referenced
this pull request
Nov 3, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surprisingly,
PyLong_Typedoesn't implement vectorcall, so this PR adds it.It should improve performance a bit and I need
int(True)to stay on trace to test #109369