bpo-35502: Fix reference leaks in ElementTree.TreeBuilder. #11170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
added
type-bug
vstinner
reviewed
Dec 18, 2018
vstinner
reviewed
Dec 18, 2018
| @@ -0,0 +1,2 @@ | |||
| Fixed reference leaks in :class:`xml.etree.ElementTree.TreeBuilder` in case | |||
| of unfinished building of the tree. | |||
Member
There was a problem hiding this comment.
I'm not sure that the error is restricted to "unfinished building of the tree", it's more generally caused by syntax errors: https://bugs.python.org/issue35502#msg332051
Member
Author
|
Thank you @vstinner for your review. I tried to address your comments. |
Contributor
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-11217 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 18, 2018
…11170) (cherry picked from commit d2a75c6) Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Dec 18, 2018
(cherry picked from commit d2a75c6) Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue35502