-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
gh-111972: unicode: Make ucnhash_capicapsule initialization thread-safe
#112249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
colesbury
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also need to handle the case 'N' in _PyUnicode_DecodeUnicodeEscapeInternal.
|
Should we do something with cpython/Objects/unicodeobject.c Lines 15445 to 15460 in 14fd86a
|
colesbury
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_PyUnicode_Fini looks fine. I don't think it needs any special handling.
|
@erlend-aasland, would you please review this when you get a chance? |
|
Thanks for the PR, Kirill, and thanks for the review, Sam! |
--disable-gilbuilds #111972