gh-111926: Update _PyWeakref_IS_DEAD to be thread-safe #112267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corona10
changed the title
colesbury
approved these changes
Nov 19, 2023
Contributor
colesbury
left a comment
colesbury
left a comment
There was a problem hiding this comment.
I think this is good for now, but we'll need to come back to this again after other parts of weakrefobject.c are updated.
Py_REFCNT(obj) == 0 won't be sufficient here without the GIL. Outside of destructors, Py_REFCNT() is basically an estimate subject to race conditions. We'll want a check that ob_ref_shared == _Py_REF_MERGED, but we can't rely on that test either until we make some other changes to weakrefobject.c
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: #112250 (comment)