Skip to content

gh-112405: Optimise pathlib.Path.relative_to #112406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlexWaygood merged 4 commits into from
Nov 26, 2023
Merged

gh-112405: Optimise pathlib.Path.relative_to #112406

AlexWaygood merged 4 commits into from
Nov 26, 2023

Conversation

@AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Nov 25, 2023 •
edited
Loading

On main (Windows machine, PGO-optimised build):

>python -m timeit -s "from pathlib import Path; p = Path('a/b/c/d/e/f/g')" "p.relative_to('a/b/c/d')"
Running PGUpdate|x64 interpreter...
10000 loops, best of 5: 28.7 usec per loop

With this PR:

>python -m timeit -s "from pathlib import Path; p = Path('a/b/c/d/e/f/g')" "p.relative_to('a/b/c/d')"
Running PGUpdate|x64 interpreter...
20000 loops, best of 5: 19.5 usec per loop

Fixes #112405

@AlexWaygood AlexWaygood added type-feature A feature request or enhancement performance Performance or resource usage topic-pathlib labels Nov 25, 2023
@bedevere-app bedevere-app bot mentioned this pull request Nov 25, 2023
Closed
@AlexWaygood
Copy link
Member Author

AlexWaygood commented Nov 25, 2023

itertools is an extremely fast import; this makes ~no difference to pathlib's import time :)

itamaro
itamaro approved these changes Nov 26, 2023
View reviewed changes
Copy link
Contributor

@itamaro itamaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice win!

@AlexWaygood @itamaro
Concede to the Yanks
ba3bf0c 
Co-authored-by: Itamar Oren <[email protected]>
barneygale
barneygale approved these changes Nov 26, 2023
View reviewed changes
Copy link
Contributor

@barneygale barneygale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely stuff

@AlexWaygood
Copy link
Member Author

AlexWaygood commented Nov 26, 2023

Thanks both! :D

@AlexWaygood AlexWaygood enabled auto-merge (squash) November 26, 2023 15:40
@AlexWaygood AlexWaygood merged commit 418d585 into python:main Nov 26, 2023
@AlexWaygood AlexWaygood deleted the pathlib-itertools branch November 26, 2023 15:56
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@AlexWaygood @aisk
pythongh-112405: Optimise pathlib.Path.relative_to (python#112406)
15657e2
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@AlexWaygood @Glyphack
pythongh-112405: Optimise pathlib.Path.relative_to (python#112406)
4cd08a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itamaro itamaro itamaro approved these changes

@barneygale barneygale barneygale approved these changes

Assignees

No one assigned

Labels

performance Performance or resource usage topic-pathlib type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Optimise pathlib.Path.relative_to()

3 participants

@AlexWaygood @itamaro @barneygale