gh-112414: Fix AttributeError when calling repr() on a namespace package imported with a custom loader
#112425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le imported with a custom loader
AlexWaygood
added
type-bug
AlexWaygood
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
AlexWaygood
changed the title
AttributeError when calling repr() on a module imported with a custom loaderAttributeError when calling repr() on a namespace package imported with a custom loader
serhiy-storchaka
approved these changes
Nov 27, 2023
|
Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 27, 2023
…space package imported with a custom loader (pythonGH-112425) (cherry picked from commit 0622839) Co-authored-by: Alex Waygood <[email protected]>
|
GH-112440 is a backport of this pull request to the 3.12 branch. |
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…space package imported with a custom loader (python#112425)
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…space package imported with a custom loader (python#112425)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced by #98870
ModuleType.__repr__can fail on py312+ #112414