gh-112678: Declare Tkapp_CallDeallocArgs() as static
#112679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as per PEP 7.
AlexWaygood
changed the title
Tkapp_CallDeallocArgs() as staticTkapp_CallDeallocArgs() as static
serhiy-storchaka
approved these changes
Dec 4, 2023
serhiy-storchaka
added
awaiting merge
needs backport to 3.11
|
Thanks @chrstphrchvz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Thanks @chrstphrchvz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-112690 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 4, 2023
…nGH-112679) (cherry picked from commit 23e001f) Co-authored-by: Christopher Chavez <[email protected]>
|
GH-112691 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 4, 2023
…nGH-112679) (cherry picked from commit 23e001f) Co-authored-by: Christopher Chavez <[email protected]>
serhiy-storchaka
pushed a commit
that referenced
this pull request
Dec 4, 2023
serhiy-storchaka
pushed a commit
that referenced
this pull request
Dec 4, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…as per PEP 7.
This should make no difference in functionality. According to
llvm-nm -gU Modules/_tkinter.othere are no other similar issues in this file.Tkapp_CallDeallocArgs()should bestatic#112678