gh-112736: Refactor del-safe symbol handling in subprocess #112738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpshead
reviewed
Dec 5, 2023
gpshead
approved these changes
Dec 5, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…hon#112738) Refactor delete-safe symbol handling in subprocess. Only module globals are force-cleared during interpreter finalization, using a class reference instead of individually listing the constants everywhere is simpler.
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Aug 5, 2024
…ss (python#112738) Refactor delete-safe symbol handling in subprocess. Only module globals are force-cleared during interpreter finalization, using a class reference instead of individually listing the constants everywhere is simpler.
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Aug 5, 2024
…ss (python#112738) Refactor delete-safe symbol handling in subprocess. Only module globals are force-cleared during interpreter finalization, using a class reference instead of individually listing the constants everywhere is simpler.
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Aug 5, 2024
…ss (python#112738) Refactor delete-safe symbol handling in subprocess. Only module globals are force-cleared during interpreter finalization, using a class reference instead of individually listing the constants everywhere is simpler.
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Aug 5, 2024
python#112738) Refactor delete-safe symbol handling in subprocess. Only module globals are force-cleared during interpreter finalization, using a class reference instead of individually listing the constants everywhere is simpler.
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…hon#112738) Refactor delete-safe symbol handling in subprocess. Only module globals are force-cleared during interpreter finalization, using a class reference instead of individually listing the constants everywhere is simpler.
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Sep 6, 2024
…ss (python#112738) Refactor delete-safe symbol handling in subprocess. Only module globals are force-cleared during interpreter finalization, using a class reference instead of individually listing the constants everywhere is simpler.
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Sep 9, 2024
…ss (python#112738) Refactor delete-safe symbol handling in subprocess. Only module globals are force-cleared during interpreter finalization, using a class reference instead of individually listing the constants everywhere is simpler.
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Sep 9, 2024
…ss (python#112738) Refactor delete-safe symbol handling in subprocess. Only module globals are force-cleared during interpreter finalization, using a class reference instead of individually listing the constants everywhere is simpler.
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Sep 9, 2024
…ss (python#112738) Refactor delete-safe symbol handling in subprocess. Only module globals are force-cleared during interpreter finalization, using a class reference instead of individually listing the constants everywhere is simpler.
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Sep 9, 2024
python#112738) Refactor delete-safe symbol handling in subprocess. Only module globals are force-cleared during interpreter finalization, using a class reference instead of individually listing the constants everywhere is simpler.
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Oct 9, 2024
…ss (python#112738) Refactor delete-safe symbol handling in subprocess. Only module globals are force-cleared during interpreter finalization, using a class reference instead of individually listing the constants everywhere is simpler.
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Dec 13, 2024
python#112738) Refactor delete-safe symbol handling in subprocess. Only module globals are force-cleared during interpreter finalization, using a class reference instead of individually listing the constants everywhere is simpler.
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Dec 13, 2024
…ss (python#112738) Refactor delete-safe symbol handling in subprocess. Only module globals are force-cleared during interpreter finalization, using a class reference instead of individually listing the constants everywhere is simpler.
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Dec 13, 2024
…ss (python#112738) Refactor delete-safe symbol handling in subprocess. Only module globals are force-cleared during interpreter finalization, using a class reference instead of individually listing the constants everywhere is simpler.
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Dec 13, 2024
…ss (python#112738) Refactor delete-safe symbol handling in subprocess. Only module globals are force-cleared during interpreter finalization, using a class reference instead of individually listing the constants everywhere is simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the use of del-safe symbols so that they can be overridden in a cross-platform build environment.
Includes the first references to iOS as a platform identifier (following the acceptance of PEP 730). I was advised in an in-person chat with @ned-deily that as long as tvOS/watchOS patches didn't break anything for existing platforms, they were OK to leave in; but I'm happy to strip those out if you'd prefer.
There's no new tests... because I'm not sure what a test for this would look like. It doesn't change any runtime behavior - the change is really only observable if you're building a crossenv-style environment. I'm open to suggestions for what a test for this would entail.